[libc++][test] Skip some is_implicit_lifetime tests for apple-clang-17
#131302
Conversation
The skipping was present before but dropped. At the time it was dropped, apple-clang-17 wasn't used for CI. But today it is used at least for the "macos (generic-cxx23, macos-15)" configuration. So I think we need to skip apple-clang-17 again.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: A. Jiang (frederick-vs-ja) ChangesThe skipping was present before but dropped. At the time it was dropped in #128649, apple-clang-17 wasn't used for CI. But today it is used at least for the "macos (generic-cxx23, macos-15)" configuration. So I think we need to skip apple-clang-17 again. Full diff: https://github.com/llvm/llvm-project/pull/131302.diff 2 Files Affected:
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
index 24adec37431e7..681ad13a07dfd 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
@@ -9,7 +9,7 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16
+// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16, apple-clang-17
// <type_traits>
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
index 4bcb10d0b7579..34462f9bf0ec6 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
@@ -9,7 +9,7 @@
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16
+// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16, apple-clang-17
// <type_traits>
|
|
apple-clang-17 has been used today: |
…lvm#131438) It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported `__builtin_is_virtual_base_of` yet. And thus we need to skip the test for `is_virtual_base_of`. Follows up llvm#131302.
@frederick-vs-ja or @ldionne do you know how we started using Apple-Clang-17? I also saw you backported fixes to the LLVM-20 branch. IMO we should really avoid using Apple-Clang-17 in LLVM-20. We also don't backport Clang-21 fixes to the LLVM-20 branch. |
Apple-Clang-17 started being used silently, and it seemed that Apple-Clang-16 and 17 were randomly chosen two days ago. I really didn't know how this happened... |
…lvm#131438) It seems that Apple Clang 17 starts to be used for CI, while it hasn't supported `__builtin_is_virtual_base_of` yet. And thus we need to skip the test for `is_virtual_base_of`. Follows up llvm#131302.
The skipping was present before but dropped. At the time it was dropped in #128649, apple-clang-17 wasn't used for CI. But today it is used at least for the "macos (generic-cxx23, macos-15)" configuration. So I think we need to skip apple-clang-17 again.