[libc++][type_traits] Implements "A type trait to detect reference binding to temporary" #128649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
H-G-Hristov
force-pushed
the
hgh/libcxx/P2255R2-A_type_trait_to_detect_reference_binding_to_temporary
branch
8 times, most recently
from
8be15ab to
bf9e5d9
Compare
…nding to temporary" Implements partially: P2255R2: A type trait to detect reference binding to temporary llvm#105180 https://eel.is/c++draft/meta.type.synop https://eel.is/c++draft/meta.unary.prop Implented type traits: - [x] `reference_constructs_from_temporary` - [x] `reference_converts_from_temporary`
H-G-Hristov
force-pushed
the
hgh/libcxx/P2255R2-A_type_trait_to_detect_reference_binding_to_temporary
branch
from
bf9e5d9 to
ab21883
Compare
libcxx/include/__type_traits/reference_constructs_from_temporary.h
Outdated
Show resolved
Hide resolved
...t/std/utilities/meta/meta.unary/meta.unary.prop/reference_constructs_from_temporary.pass.cpp
Show resolved
Hide resolved
...est/std/utilities/meta/meta.unary/meta.unary.prop/reference_converts_from_temporary.pass.cpp
Outdated
Show resolved
Hide resolved
…ference_binding_to_temporary
…ference_binding_to_temporary
…ference_binding_to_temporary
…ference_binding_to_temporary
…ference_binding_to_temporary
…ference_binding_to_temporary
…ding_to_temporary' of https://github.com/H-G-Hristov/llvm-project into hgh/libcxx/P2255R2-A_type_trait_to_detect_reference_binding_to_temporary
…ference_binding_to_temporary
…ference_binding_to_temporary
|
Removed workarounds and disabled tests for unsupported compilers:
|
|
If only the check was broken, can't we just drop the check entirely? |
…ference_binding_to_temporary
Wouldn't this cause build failures in the CI if the the intrinsic isn't available? |
When is it not available? |
On Arm currently, Apple Clang |
…ference_binding_to_temporary
…ference_binding_to_temporary
frederick-vs-ja
approved these changes
Mar 7, 2025
libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/common.h
Outdated
Show resolved
Hide resolved
…ference_binding_to_temporary
philnik777
approved these changes
Mar 8, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/6282 Here is the relevant piece of the build log for the reference |
H-G-Hristov
deleted the
hgh/libcxx/P2255R2-A_type_trait_to_detect_reference_binding_to_temporary
branch
|
I guess we need to revert the drive-by changes. Not sure whether that would be temporary. At the time of last CI for this PR, the "macos (apple-configuration, macos-15)" configuration was using apple-clang-16. But today it changed to use apple-clang-17 and the tests for |
philnik777
reviewed
Apr 1, 2025
| : public bool_constant<__reference_constructs_from_temporary(_Tp, _Up)> {}; | ||
|
|
||
| template <class _Tp, class _Up> | ||
| _LIBCPP_NO_SPECIALIZATIONS inline constexpr bool reference_constructs_from_temporary_v = |
There was a problem hiding this comment.
@Zingam It looks like you forgot to add tests for the _LIBCPP_NO_SPECIALIZATIONS annotations. Could you add them in a follow-up PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements partially: P2255R2: A type trait to detect reference binding to temporary
Issue: #105180
https://eel.is/c++draft/meta.type.synop
https://eel.is/c++draft/meta.unary.prop
Implented type traits:
reference_constructs_from_temporaryreference_converts_from_temporaryCloses #129049
Minor drive-by tweak to
std::is_implicit_lifetimetests.