Skip to content

Conversation

meltq
Copy link
Contributor

@meltq meltq commented Mar 13, 2025

Fix a minor syntax error in the Sollya command in the comments of asinhf.

@llvmbot llvmbot added the libc label Mar 13, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 13, 2025

@llvm/pr-subscribers-libc

Author: Tejas Vipin (meltq)

Changes

Fix a minor syntax error in the Sollya command in the comments of asinhf.


Full diff: https://github.com/llvm/llvm-project/pull/131091.diff

1 Files Affected:

  • (modified) libc/src/math/generic/asinhf.cpp (+1-1)
diff --git a/libc/src/math/generic/asinhf.cpp b/libc/src/math/generic/asinhf.cpp
index 9cdb7b8394e9d..37b87a821222a 100644
--- a/libc/src/math/generic/asinhf.cpp
+++ b/libc/src/math/generic/asinhf.cpp
@@ -36,7 +36,7 @@ LLVM_LIBC_FUNCTION(float, asinhf, (float x)) {
     double x_d = x;
     double x_sq = x_d * x_d;
     // Generated by Sollya with:
-    // > P = fpminimax(asinh(x)/x, [|0, 2, 4, 6, 8, 10, 12, 14, 16], [|D...|],
+    // > P = fpminimax(asinh(x)/x, [|0, 2, 4, 6, 8, 10, 12, 14, 16|], [|D...|],
     //                 [0, 2^-2]);
     double p = fputil::polyeval(
         x_sq, 0.0, -0x1.555555555551ep-3, 0x1.3333333325495p-4,

@meltq
Copy link
Contributor Author

meltq commented Mar 13, 2025

@lntue requesting review

@lntue lntue merged commit b910610 into llvm:main Mar 13, 2025
16 of 17 checks passed
@meltq meltq deleted the sollya_error branch March 13, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants