Skip to content

AMDGPU: Replace some undef uses in test metadata with poison #131052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 13, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 13, 2025

@llvm/pr-subscribers-llvm-globalisel

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/131052.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll (+8-8)
diff --git a/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll b/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
index 692a33bd20ea9..834b3812673bc 100644
--- a/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
+++ b/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
@@ -1779,7 +1779,7 @@ attributes #3 = { optnone noinline "amdgpu-no-completion-action" "amdgpu-no-defa
 !2 = !{!"none"}
 !3 = !{!"int"}
 !4 = !{!""}
-!5 = !{i32 undef, i32 1}
+!5 = !{i32 poison, i32 1}
 !6 = !{i32 1, i32 2, i32 4}
 !7 = !{<4 x i32> poison, i32 0}
 !8 = !{i32 8, i32 16, i32 32}
@@ -1800,13 +1800,13 @@ attributes #3 = { optnone noinline "amdgpu-no-completion-action" "amdgpu-no-defa
 !23 = !{!"none", !"none", !"none"}
 !24 = !{!"int", !"short2", !"char3"}
 !25 = !{!"", !"", !""}
-!26 = !{half undef, i32 1}
-!27 = !{float undef, i32 1}
-!28 = !{double undef, i32 1}
-!29 = !{i8 undef, i32 1}
-!30 = !{i16 undef, i32 1}
-!31 = !{i64 undef, i32 1}
-!32 = !{ptr  addrspace(5) undef, i32 1}
+!26 = !{half poison, i32 1}
+!27 = !{float poison, i32 1}
+!28 = !{double poison, i32 1}
+!29 = !{i8 poison, i32 1}
+!30 = !{i16 poison, i32 1}
+!31 = !{i64 poison, i32 1}
+!32 = !{ptr  addrspace(5) poison, i32 1}
 !50 = !{i32 1, i32 2, i32 3}
 !51 = !{!"int  addrspace(5)*", !"int  addrspace(5)*", !"int  addrspace(5)*"}
 !60 = !{i32 1, i32 1, i32 1}

@arsenm arsenm force-pushed the users/arsenm/amdgpu/tests-replace-undef-global-initializer-with-poison branch from f553413 to e6e9821 Compare March 13, 2025 01:41
@arsenm arsenm force-pushed the users/arsenm/amdgpu/replace-undef-metadata-test-uses-with-poison branch from b88c911 to 33dd735 Compare March 13, 2025 01:41
Copy link
Contributor Author

arsenm commented Mar 13, 2025

Merge activity

  • Mar 13, 2:24 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 13, 2:41 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 13, 2:43 AM EDT: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/amdgpu/tests-replace-undef-global-initializer-with-poison branch 2 times, most recently from d06f783 to b9eb364 Compare March 13, 2025 06:37
Base automatically changed from users/arsenm/amdgpu/tests-replace-undef-global-initializer-with-poison to main March 13, 2025 06:41
@arsenm arsenm force-pushed the users/arsenm/amdgpu/replace-undef-metadata-test-uses-with-poison branch from 33dd735 to 9d61192 Compare March 13, 2025 06:41
@arsenm arsenm merged commit 9e91725 into main Mar 13, 2025
6 of 10 checks passed
@arsenm arsenm deleted the users/arsenm/amdgpu/replace-undef-metadata-test-uses-with-poison branch March 13, 2025 06:43
frederik-h pushed a commit to frederik-h/llvm-project that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants