-
Notifications
You must be signed in to change notification settings - Fork 13.6k
AMDGPU: Replace some undef uses in test metadata with poison #131052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/replace-undef-metadata-test-uses-with-poison
Mar 13, 2025
Merged
AMDGPU: Replace some undef uses in test metadata with poison #131052
arsenm
merged 1 commit into
main
from
users/arsenm/amdgpu/replace-undef-metadata-test-uses-with-poison
Mar 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2025
This was referenced Mar 13, 2025
@llvm/pr-subscribers-llvm-globalisel @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) ChangesFull diff: https://github.com/llvm/llvm-project/pull/131052.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll b/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
index 692a33bd20ea9..834b3812673bc 100644
--- a/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
+++ b/llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
@@ -1779,7 +1779,7 @@ attributes #3 = { optnone noinline "amdgpu-no-completion-action" "amdgpu-no-defa
!2 = !{!"none"}
!3 = !{!"int"}
!4 = !{!""}
-!5 = !{i32 undef, i32 1}
+!5 = !{i32 poison, i32 1}
!6 = !{i32 1, i32 2, i32 4}
!7 = !{<4 x i32> poison, i32 0}
!8 = !{i32 8, i32 16, i32 32}
@@ -1800,13 +1800,13 @@ attributes #3 = { optnone noinline "amdgpu-no-completion-action" "amdgpu-no-defa
!23 = !{!"none", !"none", !"none"}
!24 = !{!"int", !"short2", !"char3"}
!25 = !{!"", !"", !""}
-!26 = !{half undef, i32 1}
-!27 = !{float undef, i32 1}
-!28 = !{double undef, i32 1}
-!29 = !{i8 undef, i32 1}
-!30 = !{i16 undef, i32 1}
-!31 = !{i64 undef, i32 1}
-!32 = !{ptr addrspace(5) undef, i32 1}
+!26 = !{half poison, i32 1}
+!27 = !{float poison, i32 1}
+!28 = !{double poison, i32 1}
+!29 = !{i8 poison, i32 1}
+!30 = !{i16 poison, i32 1}
+!31 = !{i64 poison, i32 1}
+!32 = !{ptr addrspace(5) poison, i32 1}
!50 = !{i32 1, i32 2, i32 3}
!51 = !{!"int addrspace(5)*", !"int addrspace(5)*", !"int addrspace(5)*"}
!60 = !{i32 1, i32 1, i32 1}
|
f553413
to
e6e9821
Compare
b88c911
to
33dd735
Compare
shiltian
approved these changes
Mar 13, 2025
d06f783
to
b9eb364
Compare
Base automatically changed from
users/arsenm/amdgpu/tests-replace-undef-global-initializer-with-poison
to
main
March 13, 2025 06:41
33dd735
to
9d61192
Compare
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.