Skip to content

[mlir][MLProgram][NFC] Migrate to OpAsmAttrInterface for ASM alias generation #130481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

[mlir][MLProgram][NFC] Migrate to OpAsmAttrInterface for ASM alias generation #130481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/include/mlir/Dialect/MLProgram/IR/MLProgramAttributes.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ def MLProgram_ExternAttr : MLProgram_Attr<"Extern", [TypedAttrInterface]> {
let parameters = (ins AttributeSelfTypeParameter<"">:$type);
let mnemonic = "extern";
let assemblyFormat = "";

// Generate mnemonic alias for the attribute.
let genMnemonicAlias = 1;
}

#endif // MLPROGRAM_ATTRIBUTES
8 changes: 0 additions & 8 deletions mlir/lib/Dialect/MLProgram/IR/MLProgramDialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ struct MLProgramInlinerInterface : public DialectInlinerInterface {

struct MLProgramOpAsmDialectInterface : public OpAsmDialectInterface {
using OpAsmDialectInterface::OpAsmDialectInterface;

AliasResult getAlias(Attribute attr, raw_ostream &os) const override {
if (llvm::isa<ExternAttr>(attr)) {
os << "extern";
return AliasResult::OverridableAlias;
}
return AliasResult::NoAlias;
}
};
} // namespace

Expand Down
Loading