Skip to content

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 7, 2025

Works fine on macos, so expand the tested hosts. This should work
on windows too, but it's been a pain debugging the error on the bot.

@arsenm arsenm added backend:AMDGPU clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Mar 7, 2025 — with Graphite App
@arsenm arsenm requested review from AlexVlx and yxsamliu March 7, 2025 05:43
@llvmbot
Copy link
Member

llvmbot commented Mar 7, 2025

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Matt Arsenault (arsenm)

Changes

Works fine on macos, so expand the tested hosts. This should work
on windows too, but it's been a pain debugging the error on the bot.


Full diff: https://github.com/llvm/llvm-project/pull/130247.diff

1 Files Affected:

  • (modified) clang/test/Driver/linker-wrapper.c (+1-2)
diff --git a/clang/test/Driver/linker-wrapper.c b/clang/test/Driver/linker-wrapper.c
index 7586b87743bf5..0aa8f7d72432a 100644
--- a/clang/test/Driver/linker-wrapper.c
+++ b/clang/test/Driver/linker-wrapper.c
@@ -1,9 +1,8 @@
+// UNSUPPORTED: system-windows
 // REQUIRES: x86-registered-target
 // REQUIRES: nvptx-registered-target
 // REQUIRES: amdgpu-registered-target
 
-// REQUIRES: system-linux
-
 // An externally visible variable so static libraries extract.
 __attribute__((visibility("protected"), used)) int x;
 

Copy link
Contributor Author

arsenm commented Mar 7, 2025

Merge activity

  • Mar 7, 4:21 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 7, 4:24 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 7, 4:28 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 7, 4:30 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 7, 4:31 AM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/hip-partial-link-remove-requires-linux-2 branch from 4fa956d to 67c7e69 Compare March 7, 2025 09:22
Base automatically changed from users/arsenm/hip-partial-link-remove-requires-linux-2 to main March 7, 2025 09:24
@arsenm arsenm force-pushed the users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows branch 2 times, most recently from 56966b6 to cc6cbdd Compare March 7, 2025 09:28
Works fine on macos, so expand the tested hosts. This should work
on windows too, but it's been a pain debugging the error on the bot.
@arsenm arsenm force-pushed the users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows branch from cc6cbdd to 8e55948 Compare March 7, 2025 09:30
@arsenm arsenm merged commit c687d78 into main Mar 7, 2025
6 of 10 checks passed
@arsenm arsenm deleted the users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows branch March 7, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AMDGPU clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants