clang: Switch linker-wrapper test to unsupported windows #130247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
added
backend:AMDGPU
clang
Graphite App
|
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Matt Arsenault (arsenm) ChangesWorks fine on macos, so expand the tested hosts. This should work Full diff: https://github.com/llvm/llvm-project/pull/130247.diff 1 Files Affected:
diff --git a/clang/test/Driver/linker-wrapper.c b/clang/test/Driver/linker-wrapper.c
index 7586b87743bf5..0aa8f7d72432a 100644
--- a/clang/test/Driver/linker-wrapper.c
+++ b/clang/test/Driver/linker-wrapper.c
@@ -1,9 +1,8 @@
+// UNSUPPORTED: system-windows
// REQUIRES: x86-registered-target
// REQUIRES: nvptx-registered-target
// REQUIRES: amdgpu-registered-target
-// REQUIRES: system-linux
-
// An externally visible variable so static libraries extract.
__attribute__((visibility("protected"), used)) int x;
|
Merge activity
|
arsenm
force-pushed
the
users/arsenm/hip-partial-link-remove-requires-linux-2
branch
from
4fa956d to
67c7e69
Compare
Base automatically changed from
users/arsenm/hip-partial-link-remove-requires-linux-2
to
main
March 7, 2025 09:24
arsenm
force-pushed
the
users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows
branch
2 times, most recently
from
56966b6 to
cc6cbdd
Compare
Works fine on macos, so expand the tested hosts. This should work on windows too, but it's been a pain debugging the error on the bot.
arsenm
force-pushed
the
users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows
branch
from
cc6cbdd to
8e55948
Compare
arsenm
deleted the
users/arsenm/clang-driver-test-switch-requires-linux-to-unsupported-windows
branch
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
Works fine on macos, so expand the tested hosts. This should work on windows too, but it's been a pain debugging the error on the bot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine on macos, so expand the tested hosts. This should work
on windows too, but it's been a pain debugging the error on the bot.