[mlir][dlti] Fix query keys preallocation #127786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes upfront space allocation after llvm#126716
Member
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-dlti Author: Adam Siemieniuk (adam-smnk) ChangesFixes upfront space allocation after #126716 Full diff: https://github.com/llvm/llvm-project/pull/127786.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/DLTI/DLTI.cpp b/mlir/lib/Dialect/DLTI/DLTI.cpp
index b057554c40d8c..70e05cb4cb383 100644
--- a/mlir/lib/Dialect/DLTI/DLTI.cpp
+++ b/mlir/lib/Dialect/DLTI/DLTI.cpp
@@ -571,7 +571,8 @@ FailureOr<Attribute> dlti::query(Operation *op, ArrayRef<StringRef> keys,
return failure();
MLIRContext *ctx = op->getContext();
- SmallVector<DataLayoutEntryKey> entryKeys(keys.size());
+ SmallVector<DataLayoutEntryKey> entryKeys;
+ entryKeys.reserve(keys.size());
for (StringRef key : keys)
entryKeys.push_back(StringAttr::get(ctx, key));
|
rolfmorel
approved these changes
Feb 19, 2025
Contributor
rolfmorel
left a comment
rolfmorel
left a comment
There was a problem hiding this comment.
Ah, yeah. Should have looked more carefully at that myself.
LGTM now though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes upfront space allocation after #126716