[Mips] Reserve hardware register HWR2 #127775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wzssyqa Could you help review again? I tested this patch on x86_64 which can reproduce this failure when enable expsensive_check, the result was ok. |
|
What's is real do should be in the commit msg subject instead of where we find it. MIPS: RegisterInfo Reserved HWR2 Mention what it resolved in the description part of commit msg. |
|
OK, I would change the commit subject and commit message. |
Fix pr llvm#127553. x86_64 failed to run readcyclecounter.ll when enable expensive_check, it would error "Using an undefined physical register".
yingopq
force-pushed
the
Fix_test_fail_106318
branch
from
540f230 to
9e210ca
Compare
yingopq
changed the title
|
Please remove XFAIL in readcyclecounter.ll |
OK, removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pr #127553.
x86_64 failed to run readcyclecounter.ll when enable expensive_check,
it would error "Using an undefined physical register".