[mlir][cmake] Add missing MLIRTestDialect dependency #125004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this will fix the flaky build issue that we have in one of the bots: https://lab.llvm.org/buildbot/#/builders/50/builds/9532
|
@llvm/pr-subscribers-mlir Author: Diego Caballero (dcaballe) ChangesHopefully this will fix the flaky build issue that we have in one of the bots: https://lab.llvm.org/buildbot/#/builders/50/builds/9532 Full diff: https://github.com/llvm/llvm-project/pull/125004.diff 1 Files Affected:
diff --git a/mlir/test/lib/IR/CMakeLists.txt b/mlir/test/lib/IR/CMakeLists.txt
index e5416da70d5008..eeb9cf1e34fc8c 100644
--- a/mlir/test/lib/IR/CMakeLists.txt
+++ b/mlir/test/lib/IR/CMakeLists.txt
@@ -27,7 +27,11 @@ add_mlir_library(MLIRTestIR
TestVisitorsGeneric.cpp
EXCLUDE_FROM_LIBMLIR
+
+ DEPENDS
+ MLIRTestDialect
)
+
mlir_target_link_libraries(MLIRTestIR PUBLIC
MLIRPass
MLIRBytecodeReader
|
River707
approved these changes
Jan 30, 2025
DavidSpickett
added a commit
that referenced
this pull request
Feb 3, 2025
That Linaro has been seeing on our dylib bot: https://lab.llvm.org/staging/#/builders/171/builds/79 In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10: /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found 148 | #include "TestOps.h.inc" | ^~~~~~~~~~~~~~~ Reported in #124335 and #124485. I think this was caused by #123910, and so I've followed what #125004 did, which seems to be a follow up to that. Same kind of error. I was not able to reproduce the failure locally, but dylib and normal builds are ok with this change so I will push it and monitor the bot's results for a few days.
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 3, 2025
That Linaro has been seeing on our dylib bot: https://lab.llvm.org/staging/#/builders/171/builds/79 In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10: /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found 148 | #include "TestOps.h.inc" | ^~~~~~~~~~~~~~~ Reported in llvm/llvm-project#124335 and llvm/llvm-project#124485. I think this was caused by llvm/llvm-project#123910, and so I've followed what llvm/llvm-project#125004 did, which seems to be a follow up to that. Same kind of error. I was not able to reproduce the failure locally, but dylib and normal builds are ok with this change so I will push it and monitor the bot's results for a few days.
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 4, 2025
This is a test library which is not part of libMLIR, so it should use normal LINK_LIBS instead of mlir_target_link_libraries. This fixes an issue introduced in llvm#123910 and follows up on the fix in llvm#125004, which added the library to DEPENDS, which is not sufficient.
DavidSpickett
pushed a commit
to DavidSpickett/llvm-project
that referenced
this pull request
Feb 5, 2025
This cherry picks [mlir][cmake] Add missing MLIRTestDialect dependency (llvm#125004) (72b73c9) and [mlir] Fix build race condition in Pass Manager tests (d906da5) to the 20.x release branch. Both of these are addressing issues that started with llvm#123910, which is already on the 20.x branch. In each case the cherry-picked changes correct problems that would otherwise be a race condition in certain builds. Linaro noticed this on our flang dylib (shared library) build bot. Failures look like: In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10: /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found 148 | #include "TestOps.h.inc" | ^~~~~~~~~~~~~~~ We have tested these changes on the buildbot for the last 2 days and had no problems. Whereas before it was failing maybe 1 in 10 builds, enough that multiple people in the community noticed it. Reported in llvm#124485 and llvm#124335. Co-authored-by: Diego Caballero <[email protected]>
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 5, 2025
This is a test library which is not part of libMLIR, so it should use normal LINK_LIBS instead of mlir_target_link_libraries. This fixes an issue introduced in llvm#123910 and follows up on the fix in llvm#125004, which added the library to DEPENDS, which is not sufficient.
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 11, 2025
This is a test library which is not part of libMLIR, so it should use normal LINK_LIBS instead of mlir_target_link_libraries. This fixes an issue introduced in llvm#123910 and follows up on the fix in llvm#125004, which added the library to DEPENDS, which is not sufficient.
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
That Linaro has been seeing on our dylib bot: https://lab.llvm.org/staging/#/builders/171/builds/79 In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10: /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found 148 | #include "TestOps.h.inc" | ^~~~~~~~~~~~~~~ Reported in llvm#124335 and llvm#124485. I think this was caused by llvm#123910, and so I've followed what llvm#125004 did, which seems to be a follow up to that. Same kind of error. I was not able to reproduce the failure locally, but dylib and normal builds are ok with this change so I will push it and monitor the bot's results for a few days.
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This is a test library which is not part of libMLIR, so it should use normal LINK_LIBS instead of mlir_target_link_libraries. This fixes an issue introduced in llvm#123910 and follows up on the fix in llvm#125004, which added the library to DEPENDS, which is not sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix the flaky build issue that we have in one of the bots: https://lab.llvm.org/buildbot/#/builders/50/builds/9532