Skip to content

mlir: fatal error: 'TestOps.h.inc' file not found on linux s390x #124335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvestre opened this issue Jan 24, 2025 · 3 comments
Open

mlir: fatal error: 'TestOps.h.inc' file not found on linux s390x #124335

sylvestre opened this issue Jan 24, 2025 · 3 comments

Comments

@sylvestre
Copy link
Collaborator

log: https://llvm-jenkins.debian.net/job/llvm-toolchain-jammy-binaries/architecture=s390x,distribution=jammy,label=s390x/1911/console


FAILED: tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o 
/opt/sccache//sccache /build/source/build-llvm/./bin/clang++ -DMLIR_INCLUDE_TESTS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/test/lib/IR -I/build/source/mlir/test/lib/IR -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/include -I/build/source/mlir/include -I/build/source/build-llvm/tools/clang/stage2-bins/include -I/build/source/llvm/include -I/build/source/mlir/test/lib/IR/../Dialect/Test -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/test/lib/IR/../Dialect/Test -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/build/source/build-llvm/tools/clang/stage2-bins=../../../../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -Wundef -Werror=mismatched-tags -O2 -DNDEBUG -g1  -fno-exceptions -funwind-tables -std=c++17 -MD -MT tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o -MF tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o.d -o tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o -c /build/source/mlir/test/lib/IR/TestSymbolUses.cpp
In file included from /build/source/mlir/test/lib/IR/TestSymbolUses.cpp:9:
/build/source/mlir/test/lib/IR/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~
1 error generated.

Recent regression
range:
3274bf6..c3b40c7

@llvmbot
Copy link
Member

llvmbot commented Jan 24, 2025

@llvm/issue-subscribers-mlir

Author: Sylvestre Ledru (sylvestre)

log: https://llvm-jenkins.debian.net/job/llvm-toolchain-jammy-binaries/architecture=s390x,distribution=jammy,label=s390x/1911/console

FAILED: tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o 
/opt/sccache//sccache /build/source/build-llvm/./bin/clang++ -DMLIR_INCLUDE_TESTS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/test/lib/IR -I/build/source/mlir/test/lib/IR -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/include -I/build/source/mlir/include -I/build/source/build-llvm/tools/clang/stage2-bins/include -I/build/source/llvm/include -I/build/source/mlir/test/lib/IR/../Dialect/Test -I/build/source/build-llvm/tools/clang/stage2-bins/tools/mlir/test/lib/IR/../Dialect/Test -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/build/source/build-llvm/tools/clang/stage2-bins=../../../../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -Wundef -Werror=mismatched-tags -O2 -DNDEBUG -g1  -fno-exceptions -funwind-tables -std=c++17 -MD -MT tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o -MF tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o.d -o tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSymbolUses.cpp.o -c /build/source/mlir/test/lib/IR/TestSymbolUses.cpp
In file included from /build/source/mlir/test/lib/IR/TestSymbolUses.cpp:9:
/build/source/mlir/test/lib/IR/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~
1 error generated.

Recent regression
range:
3274bf6..c3b40c7

@DavidSpickett
Copy link
Collaborator

See also #124485, it's happening only some of the time on our build bot.

DavidSpickett added a commit that referenced this issue Feb 3, 2025
That Linaro has been seeing on our dylib bot:
https://lab.llvm.org/staging/#/builders/171/builds/79

In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

Reported in #124335 and
#124485.

I think this was caused by #123910,
and so I've followed what #125004 did,
which seems to be a follow up to that. Same kind of error.

I was not able to reproduce the failure locally, but dylib and
normal builds are ok with this change so I will push it and monitor
the bot's results for a few days.
github-actions bot pushed a commit to arm/arm-toolchain that referenced this issue Feb 3, 2025
That Linaro has been seeing on our dylib bot:
https://lab.llvm.org/staging/#/builders/171/builds/79

In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

Reported in llvm/llvm-project#124335 and
llvm/llvm-project#124485.

I think this was caused by llvm/llvm-project#123910,
and so I've followed what llvm/llvm-project#125004 did,
which seems to be a follow up to that. Same kind of error.

I was not able to reproduce the failure locally, but dylib and
normal builds are ok with this change so I will push it and monitor
the bot's results for a few days.
@DavidSpickett
Copy link
Collaborator

Based on the file name in the error, I think 72b73c9 fixed this.

I'm about to cherry pick that to 20.x.

DavidSpickett pushed a commit to DavidSpickett/llvm-project that referenced this issue Feb 5, 2025
This cherry picks
[mlir][cmake] Add missing MLIRTestDialect dependency (llvm#125004) (72b73c9)
and
[mlir] Fix build race condition in Pass Manager tests (d906da5)
to the 20.x release branch.

Both of these are addressing issues that started with
llvm#123910, which is already on the 20.x branch.

In each case the cherry-picked changes correct problems that would otherwise be
a race condition in certain builds. Linaro noticed this on our flang dylib (shared library)
build bot.

Failures look like:
In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

We have tested these changes on the buildbot for the last 2 days and had no problems.
Whereas before it was failing maybe 1 in 10 builds, enough that multiple people
in the community noticed it.

Reported in llvm#124485 and
llvm#124335.

Co-authored-by: Diego Caballero <[email protected]>
Icohedron pushed a commit to Icohedron/llvm-project that referenced this issue Feb 11, 2025
That Linaro has been seeing on our dylib bot:
https://lab.llvm.org/staging/#/builders/171/builds/79

In file included from /home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/TestPassManager.cpp:10:
/home/tcwg-buildbot/worker/flang-aarch64-dylib/llvm-project/mlir/test/lib/Pass/../Dialect/Test/TestOps.h:148:10: fatal error: 'TestOps.h.inc' file not found
  148 | #include "TestOps.h.inc"
      |          ^~~~~~~~~~~~~~~

Reported in llvm#124335 and
llvm#124485.

I think this was caused by llvm#123910,
and so I've followed what llvm#125004 did,
which seems to be a follow up to that. Same kind of error.

I was not able to reproduce the failure locally, but dylib and
normal builds are ok with this change so I will push it and monitor
the bot's results for a few days.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants