Skip to content

[ConstantFolding] Add ilogb in isMathLibCallNoop #122582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 20, 2025
Merged

[ConstantFolding] Add ilogb in isMathLibCallNoop #122582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5f29f64
[LibCallShrinkWrap] Added ilogb in performCallErrors()
kshitijvp Jan 11, 2025
c171c4d
[ConstantFolding] Added ilogb in isMathLibCallNoop()
kshitijvp Jan 11, 2025
9c58c9c
added more tests
kshitijvp Jan 11, 2025
05e14ed
made changes to test file
kshitijvp Jan 14, 2025
48935e7
fixed newline
kshitijvp Jan 14, 2025
56acc7f
added strictfp tests
kshitijvp Jan 14, 2025
9ae6faf
minor change
kshitijvp Jan 15, 2025
685ce57
removed whitespace
kshitijvp Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/lib/Analysis/ConstantFolding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3807,6 +3807,9 @@ bool llvm::isMathLibCallNoop(const CallBase *Call,
case LibFunc_log10f:
return Op.isNaN() || (!Op.isZero() && !Op.isNegative());

case LibFunc_ilogb:
return !Op.isNaN() && !Op.isZero() && !Op.isInfinity();

case LibFunc_expl:
case LibFunc_exp:
case LibFunc_expf:
Expand Down
213 changes: 213 additions & 0 deletions llvm/test/Transforms/InstSimplify/pr122582.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,213 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
; RUN: opt < %s -passes=instsimplify -S | FileCheck %s

define i32 @ilogbf_const1() {
; CHECK-LABEL: define i32 @ilogbf_const1() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 7.000000e+00)
; CHECK-NEXT: ret i32 2
;
%r = call i32 @ilogbf(float 7.000000e+00)
ret i32 %r
}

define i32 @ilogb_const1() {
; CHECK-LABEL: define i32 @ilogb_const1() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
; CHECK-NEXT: ret i32 2
;
%r = call i32 @ilogb(double -7.000000e+00)
ret i32 %r
}

define i32 @ilogbf_const2() {
; CHECK-LABEL: define i32 @ilogbf_const2() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 5.000000e-01)
; CHECK-NEXT: ret i32 -1
;
%r = call i32 @ilogbf(float 5.000000e-01)
ret i32 %r
}

define i32 @ilogb_const2() {
; CHECK-LABEL: define i32 @ilogb_const2() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -5.000000e-01)
; CHECK-NEXT: ret i32 -1
;
%r = call i32 @ilogb(double -5.000000e-01)
ret i32 %r
}

define i32 @ilogbf_zero() {
; CHECK-LABEL: define i32 @ilogbf_zero() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0.000000e+00)
ret i32 %r
}

define i32 @ilogb_zero() {
; CHECK-LABEL: define i32 @ilogb_zero() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0.000000e+00)
ret i32 %r
}

define i32 @ilogbf_neg_zero() {
; CHECK-LABEL: define i32 @ilogbf_neg_zero() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float -0.000000e+00)
ret i32 %r
}

define i32 @ilogb_neg_zero() {
; CHECK-LABEL: define i32 @ilogb_neg_zero() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double -0.000000e+00)
ret i32 %r
}

define i32 @ilogbf_inf() {
; CHECK-LABEL: define i32 @ilogbf_inf() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0x7FF0000000000000)
ret i32 %r
}

define i32 @ilogb_inf() {
; CHECK-LABEL: define i32 @ilogb_inf() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0x7FF0000000000000)
ret i32 %r
}

define i32 @ilogbf_nan() {
; CHECK-LABEL: define i32 @ilogbf_nan() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0x7FF8000000000000)
ret i32 %r
}

define i32 @ilogb_nan() {
; CHECK-LABEL: define i32 @ilogb_nan() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0x7FF8000000000000)
ret i32 %r
}

define i32 @ilogbf_zero_readnone() {
; CHECK-LABEL: define i32 @ilogbf_zero_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0.000000e+00) #[[ATTR1:[0-9]+]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0.000000e+00) readnone
ret i32 %r
}

define i32 @ilogb_zero_readnone() {
; CHECK-LABEL: define i32 @ilogb_zero_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0.000000e+00) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0.000000e+00) readnone
ret i32 %r
}

define i32 @ilogbf_neg_zero_readnone() {
; CHECK-LABEL: define i32 @ilogbf_neg_zero_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float -0.000000e+00) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float -0.000000e+00) readnone
ret i32 %r
}

define i32 @ilogb_neg_zero_readnone() {
; CHECK-LABEL: define i32 @ilogb_neg_zero_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -0.000000e+00) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double -0.000000e+00) readnone
ret i32 %r
}

define i32 @ilogbf_inf_readnone() {
; CHECK-LABEL: define i32 @ilogbf_inf_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF0000000000000) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0x7FF0000000000000) readnone
ret i32 %r
}

define i32 @ilogb_inf_readnone() {
; CHECK-LABEL: define i32 @ilogb_inf_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF0000000000000) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0x7FF0000000000000) readnone
ret i32 %r
}

define i32 @ilogbf_nan_readnone() {
; CHECK-LABEL: define i32 @ilogbf_nan_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float 0x7FF8000000000000) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float 0x7FF8000000000000) readnone
ret i32 %r
}

define i32 @ilogb_nan_readnone() {
; CHECK-LABEL: define i32 @ilogb_nan_readnone() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double 0x7FF8000000000000) #[[ATTR1]]
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double 0x7FF8000000000000) readnone
ret i32 %r
}

define i32 @ilogbf_poison() {
; CHECK-LABEL: define i32 @ilogbf_poison() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogbf(float poison)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogbf(float poison)
ret i32 %r
}

define i32 @ilogb_poison() {
; CHECK-LABEL: define i32 @ilogb_poison() {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double poison)
; CHECK-NEXT: ret i32 [[R]]
;
%r = call i32 @ilogb(double poison)
ret i32 %r
}

define i32 @ilogb_const1_1() strictfp {
; CHECK-LABEL: define i32 @ilogb_const1_1(
; CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
; CHECK-NEXT: [[R:%.*]] = call i32 @ilogb(double -7.000000e+00)
; CHECK-NEXT: ret i32 2
;
%r = call i32 @ilogb(double -7.000000e+00)
ret i32 %r
}

declare i32 @ilogbf(float)
declare i32 @ilogb(double)
Loading