[docs] remove some out-of-date content in LLVM Programmer's Manual. #119565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the part about implicit conversion from an iterator to a pointer. This part of the manual was written 14 years ago, in: llvm@37027c3 There do exist a type casting operator in `ilist` then: https://github.com/llvm/llvm-project/blob/37027c30ec526afe3bb571df6f8701bf0d322f22/llvm/include/llvm/ADT/ilist.h#L192-L194 But it has been remove since 2016: llvm@f197b1f So I think it makes sense to remove this part to avoid mislead new contributors.
nikic
approved these changes
Dec 11, 2024
hstk30-hw
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the part about implicit conversion from an iterator to a pointer.
This part of the manual was written 14 years ago, in: 37027c3
There do exist a type casting operator in
ilistthen:llvm-project/llvm/include/llvm/ADT/ilist.h
Lines 192 to 194 in 37027c3
But it has been remove since 2016: f197b1f
So I think it makes sense to remove this part to avoid mislead new contributors.