Skip to content

[AMDGPU][SIOptimizeVGPRLiveRange] Add setpreservesCFG in the legacy pass flow. #118256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cdevadas
Copy link
Collaborator

@cdevadas cdevadas commented Dec 2, 2024

No description provided.

Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “FP Bundles” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

cdevadas commented Dec 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cdevadas cdevadas requested review from arsenm and optimisan December 2, 2024 06:02
@cdevadas cdevadas marked this pull request as ready for review December 2, 2024 06:02
@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Christudasan Devadasan (cdevadas)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/118256.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp (+1)
diff --git a/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp b/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
index e0ba5fa06f37a2..ff0b9b4a7574bf 100644
--- a/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
+++ b/llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
@@ -155,6 +155,7 @@ class SIOptimizeVGPRLiveRangeLegacy : public MachineFunctionPass {
   }
 
   void getAnalysisUsage(AnalysisUsage &AU) const override {
+    AU.setPreservesCFG();
     AU.addRequired<LiveVariablesWrapperPass>();
     AU.addRequired<MachineDominatorTreeWrapperPass>();
     AU.addRequired<MachineLoopInfoWrapperPass>();

Copy link
Collaborator

@rovka rovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

cdevadas commented Dec 2, 2024

Merge activity

  • Dec 2, 12:44 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 2, 12:46 PM EST: A user merged this pull request with Graphite.

@cdevadas cdevadas merged commit c16c0e2 into main Dec 2, 2024
12 checks passed
@cdevadas cdevadas deleted the users/cdevadas/vgpr-lr-opt-setpreservecfg-in-legacy-flow branch December 2, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants