-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[ExecutionEngine] reinstate necessary include for building with -DLLVM_USE_INTEL_JITEVENTS
#117949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps we should only include map if |
Fine by me to put it behind the |
@kazutakahirata, since your commit broke compilation here, can you please let us know how you'd prefer to be fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for being late in getting back to this.
Thanks for the review. Any thoughts on whether this should move behind the Also, as I don't have the commit rights, I cannot merge this myself - would appreciate if someone could push the button. :) |
Ping @kazutakahirata - given that this your cleanup (at least partially automated AFAIU?), it would be good to ensure that this doesn't happen again for the next clean-up. If moving this behind the respective |
Ping @kazutakahirata; please either merge this PR (I don't have the commit bit), or - preferably - respond to my question above. |
Ping @kazutakahirata |
Based on llvm-project/llvm/Maintainers.md Lines 353 to 356 in 03e7862
perhaps @lhames can chime in here (or simply merge)? Not sure whose maintainership this falls under, but I'm not successful in getting a response here. |
Sorry again for being so late in getting back to you. Yes, moving the include behind |
I've created #124083. |
It would have been a trivial update to this PR, but whatever gets this fixed. ;-) |
Obsoleted by #124083 |
This is a build regression from 1f4d91e when using
-DLLVM_USE_INTEL_JITEVENTS=ON
(already commented by @Zentrik on the commit), asstd::map
is evidently used further down in that TUllvm-project/llvm/lib/ExecutionEngine/Orc/TargetProcess/JITLoaderVTune.cpp
Line 115 in c8cd497
CC @kazutakahirata