[libc][bazel] config macros is a support library #115776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously __support_macros_config was a cc_library, but making it a libc_support_library makes things cleaner.
|
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesPreviously __support_macros_config was a cc_library, but making it a Full diff: https://github.com/llvm/llvm-project/pull/115776.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 7a6d1cf2e9c6de..69a0dada23b4cd 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -53,7 +53,7 @@ config_setting(
################################## Base Config #################################
-cc_library(
+libc_support_library(
name = "__support_macros_config",
hdrs = ["src/__support/macros/config.h"],
)
|
lntue
approved these changes
Nov 11, 2024
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
Previously __support_macros_config was a cc_library, but making it a libc_support_library makes things cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously __support_macros_config was a cc_library, but making it a
libc_support_library makes things cleaner.