[TableGen] Handle Windows line endings in x86-fold-tables.td test #112997
Conversation
dpaoliello
changed the title
|
Hi, this is causing a failure on the aix bot https://lab.llvm.org/buildbot/#/builders/64/builds/1269 would you be able to take a look? The cause is because |
|
It's possible that the original issue (CRLF checkouts on the Windows bots) is resolved now, thanks to the revert and restart of the buildbots (see https://discourse.llvm.org/t/windows-premerge-buildbot-broken-for-5-days/82571/8). So in that case we could revert this, and possibly add a It's a bit tricky to test it though - you'd need to run it through some other CI mechanism (as the regular buildbot doesn't apply |
Ah, perfect, I was going to ask if there was a way to do that: should have a PR out shortly... |
|
Given that we've seen this issue on AIX before, and there wasn't a good place to only use the internal shell for a single test, I decided to modify lit to always use the internal shell on AIX: #113355 |
Diff on AIX doesn't have all the required features used in tests (see <#108871> and <#112997 (comment)>), so always use the internal shell.
Diff on AIX doesn't have all the required features used in tests (see <llvm#108871> and <llvm#112997 (comment)>), so always use the internal shell.
Diff on AIX doesn't have all the required features used in tests (see <llvm/llvm-project#108871> and <llvm/llvm-project#112997 (comment)>), so always use the internal shell.
The x86-fold-tables.td has been failing for me and in CI if Git happens to decide to check out the baseline file with Windows line endings.
This fix for this is to add the
--strip-trailing-croption to diff to normalize the line endings before comparing them.