Add 64bit atomic check in the is_always_lock_free_pass test. #111540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this test is completely xfailed. But this test works on A and R profile, not in v7M profile. Because the test contain cases in which m-profile will fail for atomic types greater than 4 bytes in size.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: None (simpal01) ChangesCurrently this test is completely xfailed as part of the patch #106077. But this test works on A and R profile, not in v7M profile. Because the test contain cases in which m-profile will fail for atomic types greater than 4 bytes in size. Full diff: https://github.com/llvm/llvm-project/pull/111540.diff 1 Files Affected:
diff --git a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
index 1ebe31375079b8..e922bc7413514a 100644
--- a/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
+++ b/libcxx/test/std/atomics/atomics.lockfree/is_always_lock_free.pass.cpp
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14
-// XFAIL: LIBCXX-PICOLIBC-FIXME
+// XFAIL: !has-64-bit-atomics
// <atomic>
//
|
ldionne
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this test is completely xfailed as part of the patch #106077. But this test works on A and R profile, not in v7M profile. Because the test contain cases in which m-profile will fail for atomic types greater than 4 bytes in size.