[libc] Add Linux mman extension remap_file_pages. #110307

AlyElashram · 2024-09-27T18:06:23Z

Create remap_file_pages.h/.cpp wrapper for the linux sys call.
Add UnitTests for remap_file_pages
Add function to libc/spec/linux.td
Add Function spec to mman.yaml

- Add UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

github-actions · 2024-09-27T18:06:44Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvmbot · 2024-09-27T18:07:21Z

@llvm/pr-subscribers-libc

Author: Aly ElAshram (AlyElashram)

Changes

Create remap_file_pages.h/.cpp wrapper for the linux sys call.
Add UnitTests for remap_file_pages
Add function to libc/spec/linux.td
Add Function spec to mman.yaml

Full diff: https://github.com/llvm/llvm-project/pull/110307.diff

8 Files Affected:

(modified) libc/newhdrgen/yaml/sys/mman.yaml (+10)
(modified) libc/spec/linux.td (+11)
(modified) libc/src/sys/mman/CMakeLists.txt (+7)
(modified) libc/src/sys/mman/linux/CMakeLists.txt (+13)
(added) libc/src/sys/mman/linux/remap_file_pages.cpp (+44)
(added) libc/src/sys/mman/remap_file_pages.h (+21)
(modified) libc/test/src/sys/mman/linux/CMakeLists.txt (+17)
(added) libc/test/src/sys/mman/linux/remap_file_pages_test.cpp (+74)

diff --git a/libc/newhdrgen/yaml/sys/mman.yaml b/libc/newhdrgen/yaml/sys/mman.yaml
index 272e7e2af16aaf..2f5f199bddec83 100644
--- a/libc/newhdrgen/yaml/sys/mman.yaml
+++ b/libc/newhdrgen/yaml/sys/mman.yaml
@@ -98,6 +98,16 @@ functions:
       - type: void *
       - type: size_t
       - type: int
+  - name: remap_file_pages
+    standards:
+      - LINUX
+    return_type: int
+    arguments:
+      - type: void *
+      - type: size_t
+      - type: int
+      - type: size_t
+      - type: int
   - name: shm_open
     standards:
       - POSIX
diff --git a/libc/spec/linux.td b/libc/spec/linux.td
index 395c2a6fe853a7..4aaf18b0803f3d 100644
--- a/libc/spec/linux.td
+++ b/libc/spec/linux.td
@@ -103,6 +103,17 @@ def Linux : StandardSpec<"Linux"> {
             ArgSpec<UnsignedIntType>,
           ]
         >,
+         FunctionSpec<
+          "remap_file_pages",
+          RetValSpec<IntType>,
+          [
+            ArgSpec<VoidPtr>,
+            ArgSpec<SizeTType>,
+            ArgSpec<IntType>,
+            ArgSpec<SizeTType>,
+            ArgSpec<IntType>,
+          ]
+        >,
       ]  // Functions
   >;
 
diff --git a/libc/src/sys/mman/CMakeLists.txt b/libc/src/sys/mman/CMakeLists.txt
index 9c74202a09f035..4ea43e14be0297 100644
--- a/libc/src/sys/mman/CMakeLists.txt
+++ b/libc/src/sys/mman/CMakeLists.txt
@@ -86,6 +86,13 @@ add_entrypoint_object(
     .${LIBC_TARGET_OS}.msync
 )
 
+add_entrypoint_object(
+  remap_file_pages
+  ALIAS
+  DEPENDS
+  .${LIBC_TARGET_OS}.remap_file_pages
+)
+
 add_entrypoint_object(
   shm_open
   ALIAS
diff --git a/libc/src/sys/mman/linux/CMakeLists.txt b/libc/src/sys/mman/linux/CMakeLists.txt
index 00f4f0e64ec06b..f673d47ba96aef 100644
--- a/libc/src/sys/mman/linux/CMakeLists.txt
+++ b/libc/src/sys/mman/linux/CMakeLists.txt
@@ -153,6 +153,19 @@ add_entrypoint_object(
     libc.src.errno.errno
 )
 
+add_entrypoint_object(
+  remap_file_pages
+  SRCS
+    remap_file_pages.cpp.cpp
+  HDRS
+    ../remap_file_pages.h.h
+  DEPENDS
+    libc.include.sys_mman
+    libc.include.sys_syscall
+    libc.src.__support.OSUtil.osutil
+    libc.src.errno.errno
+)
+
 add_header_library(
   shm_common
   HDRS
diff --git a/libc/src/sys/mman/linux/remap_file_pages.cpp b/libc/src/sys/mman/linux/remap_file_pages.cpp
new file mode 100644
index 00000000000000..074d24d7c9b435
--- /dev/null
+++ b/libc/src/sys/mman/linux/remap_file_pages.cpp
@@ -0,0 +1,44 @@
+//===----- Linux implementation of the POSIX remap_file_pages function ----===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include <src/sys/mman/remap_file_pages.h>
+
+#include "src/__support/OSUtil/syscall.h" // For internal syscall function.
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+#include "src/errno/libc_errno.h"
+#include <sys/syscall.h>          // For syscall numbers.
+
+namespace LIBC_NAMESPACE_DECL {
+
+// This function is currently linux only. It has to be refactored suitably if
+// remap_file_pages is to be supported on non-linux operating systems also.
+LLVM_LIBC_FUNCTION(int, remap_file_pages,
+                   (void *addr, size_t size, int prot, size_t pgoff, int flags))
+                    {
+#ifdef SYS_remap_file_pages
+  long syscall_number = SYS_remap_file_pages;
+#else
+#error "remap_file_pages syscall is not available."
+#endif
+
+
+  int ret = LIBC_NAMESPACE::syscall_impl<int>(
+  syscall_number, reinterpret_cast<long>(addr), size, prot, pgoff, flags);
+
+  // A negative return value indicates an error with the magnitude of the
+  // value being the error code.
+  if (ret < 0) {
+    libc_errno = ret;
+    return -1;
+  }
+
+  return 0;
+}
+
+} // namespace LIBC_NAMESPACE_DECL
\ No newline at end of file
diff --git a/libc/src/sys/mman/remap_file_pages.h b/libc/src/sys/mman/remap_file_pages.h
new file mode 100644
index 00000000000000..cfb540fd904140
--- /dev/null
+++ b/libc/src/sys/mman/remap_file_pages.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for remap_file_pages function -----*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
+#define LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
+
+#include "src/__support/macros/config.h"
+#include <sys/mman.h>
+
+namespace LIBC_NAMESPACE_DECL {
+
+int remap_file_pages(void *addr, size_t size, int prot, size_t pgoff, int flags);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif //LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
diff --git a/libc/test/src/sys/mman/linux/CMakeLists.txt b/libc/test/src/sys/mman/linux/CMakeLists.txt
index b63c76f4306fac..3718f732b425f6 100644
--- a/libc/test/src/sys/mman/linux/CMakeLists.txt
+++ b/libc/test/src/sys/mman/linux/CMakeLists.txt
@@ -128,6 +128,23 @@ add_libc_unittest(
     libc.test.UnitTest.ErrnoSetterMatcher
 )
 
+add_libc_unittest(
+  remap_file_pages_test
+  SUITE
+    libc_sys_mman_unittests
+  SRCS
+    remap_file_pages_test.cpp
+  DEPENDS
+    libc.include.sys_mman
+    libc.src.unistd.sysconf
+    libc.test.UnitTest.Test
+    libc.test.UnitTest.ErrnoSetterMatcher
+    libc.src.sys.mman.remap_file_pages
+    libc.src.errno.errno
+    libc.src.sys.mman.mmap
+    libc.src.sys.mman.munmap
+)
+
 add_libc_unittest(
   shm_test
   SUITE
diff --git a/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp b/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
new file mode 100644
index 00000000000000..270ae4b6701e97
--- /dev/null
+++ b/libc/test/src/sys/mman/linux/remap_file_pages_test.cpp
@@ -0,0 +1,74 @@
+//===-- Unittests for remap_file_pages ------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/errno/libc_errno.h"
+#include "src/sys/mman/mmap.h"
+#include "src/sys/mman/munmap.h"
+#include "src/sys/mman/remap_file_pages.h"
+#include "test/UnitTest/ErrnoSetterMatcher.h"
+#include "test/UnitTest/Test.h"
+#include "src/unistd/sysconf.h"
+
+#include <sys/mman.h>
+
+
+using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Fails;
+using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
+
+TEST(LlvmLibcRemapFilePagesTest, NoError) {
+  size_t page_size = sysconf(_SC_PAGE_SIZE);
+  ASSERT_GT(page_size, size_t(0));
+
+  // First, allocate some memory using mmap
+  size_t alloc_size = 2 * page_size;
+  LIBC_NAMESPACE::libc_errno = 0;
+  void *addr = LIBC_NAMESPACE::mmap(nullptr, alloc_size, PROT_READ | PROT_WRITE,
+                                    MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+  ASSERT_ERRNO_SUCCESS();
+  EXPECT_NE(addr, MAP_FAILED);
+
+  // Reset error number for the new function
+  LIBC_NAMESPACE::libc_errno = 0;
+
+  // Now try to remap the pages
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ, page_size, 0),
+              Succeeds());
+
+  // Reset error number for the new function
+  LIBC_NAMESPACE::libc_errno = 0;
+
+  // Clean up
+  EXPECT_THAT(LIBC_NAMESPACE::munmap(addr, alloc_size), Succeeds());
+}
+
+TEST(LlvmLibcRemapFilePagesTest, ErrorInvalidFlags) {
+  size_t page_size = sysconf(_SC_PAGESIZE);
+  ASSERT_GT(page_size, size_t(0));
+
+  void *addr = LIBC_NAMESPACE::mmap(nullptr, page_size, PROT_READ | PROT_WRITE,
+                                    MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+  ASSERT_NE(addr, MAP_FAILED);
+
+  // Try to remap pages with an invalid flag MAP_PRIVATE
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(addr, page_size, PROT_READ, 0, MAP_PRIVATE),
+              Fails(EINVAL));
+
+  // Clean up
+  EXPECT_THAT(LIBC_NAMESPACE::munmap(addr, page_size), Succeeds());
+}
+
+TEST(LlvmLibcRemapFilePagesTest, ErrorInvalidAddress) {
+  size_t page_size = sysconf(_SC_PAGESIZE);
+  ASSERT_GT(page_size, size_t(0));
+
+  // Use an address that we haven't mapped
+  void *invalid_addr = reinterpret_cast<void*>(0x12345000);
+
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(invalid_addr, page_size, PROT_READ, 0, 0),
+              Fails(EINVAL));
+}
\ No newline at end of file

AlyElashram · 2024-09-27T18:08:47Z

@SchrodingerZhu I'm not really certain of the testing macros used , I kind of "monkey see monkey do"-ed them from other test files, so please let me know if something is off.

michaelrj-google

This looks like a good start, I left some comments for minor things to fix.

michaelrj-google · 2024-09-27T18:27:36Z

libc/src/sys/mman/linux/remap_file_pages.cpp

+  return 0;
+}
+
+} // namespace LIBC_NAMESPACE_DECL


nit: needs ending newline

michaelrj-google · 2024-09-27T18:28:12Z

libc/test/src/sys/mman/linux/remap_file_pages_test.cpp

+
+  EXPECT_THAT(LIBC_NAMESPACE::remap_file_pages(invalid_addr, page_size, PROT_READ, 0, 0),
+              Fails(EINVAL));
+}


nit: needs ending newline

michaelrj-google · 2024-09-27T18:31:12Z

libc/src/sys/mman/linux/remap_file_pages.cpp

@@ -0,0 +1,44 @@
+//===----- Linux implementation of the POSIX remap_file_pages function ----===//


nit: since this function isn't actually from POSIX, you can remove that from the title here.

michaelrj-google · 2024-09-27T18:31:34Z

libc/src/sys/mman/linux/remap_file_pages.cpp

+// This function is currently linux only. It has to be refactored suitably if
+// remap_file_pages is to be supported on non-linux operating systems also.


nit: since this is a linux specific function you don't need this comment.

michaelrj-google · 2024-09-27T18:32:51Z

libc/src/sys/mman/linux/remap_file_pages.cpp

+                   (void *addr, size_t size, int prot, size_t pgoff, int flags))
+                    {
+#ifdef SYS_remap_file_pages
+  long syscall_number = SYS_remap_file_pages;


there's only one possible syscall here, so you can move the syscall into this ifdef like this (though you may need to reformat the code):

Suggested change

long syscall_number = SYS_remap_file_pages;

int ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_remap_file_pages, reinterpret_cast<long>(addr), size, prot, pgoff, flags);

michaelrj-google · 2024-09-27T18:34:23Z

libc/src/sys/mman/remap_file_pages.h

+#define LLVM_LIBC_SRC_SYS_MMAN_REMAP_FILE_PAGES_H
+
+#include "src/__support/macros/config.h"
+#include <sys/mman.h>


we don't need sys/mman.h here, since this function doesn't take any types that it defines. Instead this should just be stddef.h

Suggested change

#include <sys/mman.h>

#include <stddef.h>

michaelrj-google · 2024-09-27T18:34:52Z

libc/src/sys/mman/linux/remap_file_pages.cpp

+//
+//===----------------------------------------------------------------------===//
+
+#include <src/sys/mman/remap_file_pages.h>


this should use "quote marks" instead of <angle brackets>

Suggested change

#include <src/sys/mman/remap_file_pages.h>

#include "src/sys/mman/remap_file_pages.h"

michaelrj-google · 2024-09-27T18:36:56Z

libc/newhdrgen/yaml/sys/mman.yaml

@@ -98,6 +98,16 @@ functions:
      - type: void *
      - type: size_t
      - type: int
+  - name: remap_file_pages
+    standards:
+      - LINUX


nit: in other places it's capitalized as Linux

Suggested change

- LINUX

- Linux

github-actions · 2024-09-27T20:20:53Z

✅ With the latest revision this PR passed the C/C++ code formatter.

…d UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

AlyElashram · 2024-09-27T23:45:25Z

I have one concern , I downloaded the logs for the previous build and didn't find the new remap_file_pages_test test run after searching for it. Shouldn't this be a concern? @michaelrj-google
I've attached the logs if you would like to take a look yourself.
github-pull-requests_build_104817_linux-linux-x64.log

michaelrj-google · 2024-09-30T21:42:08Z

Ah, you need to add this function to entrypoints.txt which is the list of functions we provide for each target. If you want to see which functions are being skipped, add -DLIBC_CMAKE_VERBOSE_LOGGING=ON to your cmake command.

…d UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

AlyElashram · 2024-09-30T22:20:15Z

libc/src/sys/mman/linux/CMakeLists.txt

+    remap_file_pages.cpp.cpp
+  HDRS
+    ../remap_file_pages.h.h


this is going to cause an error most definitely.

Suggested change

remap_file_pages.cpp.cpp

HDRS

../remap_file_pages.h.h

remap_file_pages.cpp

HDRS

../remap_file_pages.h

AlyElashram · 2024-09-30T22:31:52Z

Converting this to a draft till I figure out why the tests are missing 👀

- return the negative of the return value

AlyElashram · 2024-10-01T18:09:31Z

libc/test/src/sys/mman/linux/remap_file_pages_test.cpp

+  int fd = open("/dev/zero", O_RDWR);
+  ASSERT_GT(fd, 0);
+
+  // First, allocate some memory using mmap
+  size_t alloc_size = 2 * page_size;
+  LIBC_NAMESPACE::libc_errno = 0;
+  void *addr = LIBC_NAMESPACE::mmap(nullptr, alloc_size, PROT_READ | PROT_WRITE,
+                                    MAP_SHARED, fd, 0);


I believe this makes much more sense when using remap_file_pages , instead of using MAP_PRIVATE and not having a file backed mapping. The use case of remap_file_pages should remap a file backed memory allocation if i understand correctly.

@michaelrj-google @SchrodingerZhu please correct me if I'm wrong here.

michaelrj-google · 2024-10-03T18:28:13Z

libc/test/src/sys/mman/linux/remap_file_pages_test.cpp

+  ASSERT_GT(page_size, size_t(0));
+
+  // Create a file-backed mapping
+  int fd = open("/dev/zero", O_RDWR);


If you're opening a file in a test you should use a file in the same directory as the test, similar to what's done in access_test

also small nit: this should use LIBC_NAMESPACE::open.

michaelrj-google · 2024-10-03T18:29:44Z

libc/test/src/sys/mman/linux/remap_file_pages_test.cpp

+  // Reset error number for the new function
+  LIBC_NAMESPACE::libc_errno = 0;


you don't need to reset errno here since you asserted that it succeeded above.

michaelrj-google · 2024-10-03T18:31:13Z

libc/test/src/sys/mman/linux/remap_file_pages_test.cpp

+  int fd = open("/dev/zero", O_RDWR);
+  ASSERT_GT(fd, 0);


same file path stuff as above, though make sure to use a different name since tests may be run in parallel.

- Remove errno resetting

AlyElashram · 2024-10-12T19:25:57Z

@michaelrj-google @SchrodingerZhu Pinging on this as I think it's good to go. Awaiting approval to rebase 👀

SchrodingerZhu · 2024-10-13T14:17:48Z

Hi, I’m traveling right now but I will take a look after my flight today. Michael and others are bit busy currently as they are preparing for the upcoming devconf. Thanks for your patience and apologies for the delay. Yifan Sent from Proton Mail for iOS On Sat, Oct 12, 2024 at 15:26, Aly ElAshram ***@***.***> wrote: @michaelrj-google @SchrodingerZhu Pinging on this as I think it's good to go. Awaiting approval to rebase 👀 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***> </blockquote>

SchrodingerZhu · 2024-10-14T15:21:20Z

libc/test/src/sys/mman/linux/CMakeLists.txt

+  SRCS
+    remap_file_pages_test.cpp
+  DEPENDS
+    libc.include.sys_mman


Suggested change

libc.include.sys_mman

libc.include.sys_mman

libc.include.sys_stat

SchrodingerZhu · 2024-10-14T15:40:33Z

This PR is of a good shape to go. Just some nit on header inclusion.

AlyElashram · 2024-10-14T15:49:17Z

Should I rebase and push --force-with-lease after getting 2 approvals ? or should I do it now @SchrodingerZhu ?

SchrodingerZhu · 2024-10-14T17:15:29Z

Should I rebase and push --force-with-lease after getting 2 approvals ? or should I do it now @SchrodingerZhu ?

I guess no more operation on your side is needed for now. let's wait to see if the CI is happy.

github-actions · 2024-10-14T21:04:53Z

@AlyElashram Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

Fixes llvm#110122 - Create remap_file_pages.h/.cpp wrapper for the linux sys call. - Add UnitTests for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

- Create remap_file_pages wrapper for the linux sys call.

50bf5e9

- Add UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

llvmbot added the libc label Sep 27, 2024

michaelrj-google reviewed Sep 27, 2024

View reviewed changes

fixup! - Create remap_file_pages wrapper for the linux sys call. - Ad…

5a8891a

…d UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

fixup! - Create remap_file_pages wrapper for the linux sys call. - Ad…

17d7626

…d UnitTest for remap_file_pages - Add function to libc/spec/linux.td - Add Function spec to mman.yaml

AlyElashram commented Sep 30, 2024

View reviewed changes

Remove extra file extensions

cbc1c33

AlyElashram marked this pull request as draft September 30, 2024 22:30

lntue changed the title ~~Add Linux sys call wrapper in LibC [ Issue #110122 ]~~ [libc] Add Linux mman extension remap_file_pages. Oct 1, 2024

AlyElashram added 2 commits October 1, 2024 19:32

- Remove extra file extensions

0caed2f

- return the negative of the return value

- Patch Successful Test

6cdfe53

AlyElashram commented Oct 1, 2024

View reviewed changes

AlyElashram marked this pull request as ready for review October 1, 2024 20:41

michaelrj-google reviewed Oct 3, 2024

View reviewed changes

AlyElashram added 2 commits October 4, 2024 23:44

- Add test file creation

db96b76

- Remove errno resetting

Change Test file names to be more indicative of the test

6a181ef

SchrodingerZhu requested changes Oct 14, 2024

View reviewed changes

Add Systat to header inclusion in unittest CMakeLists

09f8671

SchrodingerZhu self-requested a review October 14, 2024 17:13

SchrodingerZhu approved these changes Oct 14, 2024

View reviewed changes

SchrodingerZhu merged commit 76173b1 into llvm:main Oct 14, 2024
7 checks passed

		@@ -0,0 +1,44 @@
		//===----- Linux implementation of the POSIX remap_file_pages function ----===//

		// This function is currently linux only. It has to be refactored suitably if
		// remap_file_pages is to be supported on non-linux operating systems also.

	long syscall_number = SYS_remap_file_pages;
	int ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_remap_file_pages, reinterpret_cast<long>(addr), size, prot, pgoff, flags);

	#include <src/sys/mman/remap_file_pages.h>
	#include "src/sys/mman/remap_file_pages.h"

		// Reset error number for the new function
		LIBC_NAMESPACE::libc_errno = 0;

	libc.include.sys_mman
	libc.include.sys_mman
	libc.include.sys_stat

[libc] Add Linux mman extension remap_file_pages. #110307

[libc] Add Linux mman extension remap_file_pages. #110307

Uh oh!

Conversation

AlyElashram commented Sep 27, 2024 • edited by lntue Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2024

Uh oh!

llvmbot commented Sep 27, 2024

Uh oh!

AlyElashram commented Sep 27, 2024

Uh oh!

michaelrj-google left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AlyElashram commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelrj-google commented Sep 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlyElashram commented Sep 30, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlyElashram commented Oct 12, 2024

Uh oh!

SchrodingerZhu commented Oct 13, 2024 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SchrodingerZhu commented Oct 14, 2024

Uh oh!

AlyElashram commented Oct 14, 2024

Uh oh!

SchrodingerZhu commented Oct 14, 2024

Uh oh!

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

Uh oh!

AlyElashram commented Sep 27, 2024 •

edited by lntue

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

AlyElashram commented Sep 27, 2024 •

edited

Loading