Skip to content

Update BUILD.bazel #110170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update BUILD.bazel #110170

merged 1 commit into from
Sep 26, 2024

Conversation

norx1991
Copy link
Contributor

It was broken by #100667

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Sep 26, 2024
Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@rupprecht rupprecht merged commit d129763 into llvm:main Sep 26, 2024
8 checks passed
@rupprecht
Copy link
Collaborator

Thanks!

Copy link

@norx1991 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

hanhanW added a commit to iree-org/llvm-project that referenced this pull request Sep 27, 2024
hanhanW added a commit to iree-org/llvm-project that referenced this pull request Sep 27, 2024
hanhanW added a commit to iree-org/llvm-project that referenced this pull request Sep 27, 2024
This reverts commit d129763.

Signed-off-by: hanhanW <[email protected]>
Sterling-Augustine pushed a commit to Sterling-Augustine/llvm-project that referenced this pull request Sep 27, 2024
bjacob pushed a commit to iree-org/llvm-project that referenced this pull request Sep 30, 2024
This reverts commit d129763.

Signed-off-by: hanhanW <[email protected]>
bjacob added a commit to iree-org/iree that referenced this pull request Sep 30, 2024
Cherry-picks:
1. Cherry-picking llvm/llvm-project#110518

Carrying two local reverts:
1. Revert llvm/llvm-project#100667)
- As noted by @hanhanW on #18619,
that PR "breaks the stablehlo build. We need to wait stablehlo bumping
LLVM ahead of it and fix the issue. Then we can bump stablehlo and drop
the local commit together."
2. Revert llvm/llvm-project#110170)
   - That is just the Bazel change accompanying 1.

Signed-off-by: Benoit Jacob <[email protected]>
bjacob pushed a commit to iree-org/llvm-project that referenced this pull request Oct 1, 2024
This reverts commit d129763.

Signed-off-by: hanhanW <[email protected]>
bjacob pushed a commit to iree-org/llvm-project that referenced this pull request Oct 1, 2024
This reverts commit d129763.

Signed-off-by: hanhanW <[email protected]>
bjacob added a commit to iree-org/iree that referenced this pull request Oct 1, 2024
Existing reverts carried over:
1. Revert llvm/llvm-project#100667)
- As noted by @hanhanW on #18619,
that PR "breaks the stablehlo build. We need to wait stablehlo bumping
LLVM ahead of it and fix the issue. Then we can bump stablehlo and drop
the local commit together."
2. Revert llvm/llvm-project#110170)
   - That is just the Bazel change accompanying 1.

Signed-off-by: Benoit Jacob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants