Revert "Revert "[AArch64][AsmParser] Directives should clear transitively implied features (#106625)"" #106814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vely imp…" This reverts commit d8bffa9.
vitalybuka
commented
Aug 31, 2024
| break; | ||
| } | ||
| if (It == std::end(ExtensionMap)) | ||
| Error(CurLoc, "unsupported architectural extension: " + Name); |
Collaborator
Author
There was a problem hiding this comment.
We can't continue this loop if It == std::end(ExtensionMap)
Collaborator
Author
There was a problem hiding this comment.
but it fails tests
Collaborator
Author
|
@labrinea This PR is just for visibility. |
Collaborator
|
Raised #106850 |
nunoplopes
deleted the
revert-106813-users/vitalybuka/spr/revert-aarch64asmparser-directives-should-clear-transitively-implied-features-106625
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #106813