[NFC][TableGen] Refactor getIntrinsicFnAttributeSet
#106587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
reviewed
Aug 29, 2024
jurahul
force-pushed
the
intrinsic_emitter_fn_attributes
branch
3 times, most recently
from
b75527a to
a20dec8
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Fix intrinsic function attributes to not generate attribute sets that are empty in `getIntrinsicFnAttributeSet`. Refactor the code to use helper lambdas to get effective memory effects for an intrinsic and to check if it has non-default attributes. This emiminates one case statement in `getIntrinsicFnAttributeSet` that we generate today for the case when intrinsic attributes are default ones. Also rename `Intrinsic` to `Int` to follow the naming convention used in this file, and adjust emission code to not emit unnecessary empty line between cases generated.
jurahul
force-pushed
the
intrinsic_emitter_fn_attributes
branch
from
a20dec8 to
3310c8d
Compare
arsenm
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix intrinsic function attributes to not generate attribute sets that are empty in
getIntrinsicFnAttributeSet. Refactor the code to use helper functions to get effective memory effects for an intrinsic and to check if it has non-default attributes.This eliminates one case statement in
getIntrinsicFnAttributeSetthat we generate today for the case when intrinsic attributes are default ones.Also rename
IntrinsictoIntto follow the naming convention used in this file and adjust emission code to not emit unnecessary empty line between cases generated.