Skip to content

[CMake] Fix DynamicLibraryTests exports symbol when plugins are enabled #102941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[CMake] Fix DynamicLibraryTests exports symbol when plugins are enabled #102941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
055f83c
[𝘀𝗽𝗿] initial version
cachemeifyoucan Aug 12, 2024
94f8171
Fix build failure on PR bots
cachemeifyoucan Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/cmake/modules/AddLLVM.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ macro(add_llvm_executable name)

if (DEFINED LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES AND
NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES AND
NOT ARG_EXPORT_SYMBOLS AND NOT ARG_EXPORT_SYMBOLS_FOR_PLUGINS)
NOT ARG_EXPORT_SYMBOLS)
if(LLVM_LINKER_SUPPORTS_NO_EXPORTED_SYMBOLS)
set_property(TARGET ${name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-no_exported_symbols")
Expand Down
4 changes: 4 additions & 0 deletions llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,17 @@ set_output_directory(DynamicLibraryLib
LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}
)

set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/DynamicLibraryTests.exports)

add_llvm_unittest(DynamicLibraryTests
DynamicLibraryTest.cpp

EXPORT_SYMBOLS
)
target_link_libraries(DynamicLibraryTests PRIVATE DynamicLibraryLib)

unset(LLVM_EXPORTED_SYMBOL_FILE)

function(dynlib_add_module NAME)
add_library(${NAME} MODULE
PipSqueak.cpp
Expand Down
1 change: 1 addition & 0 deletions llvm/unittests/Support/DynamicLibrary/DynamicLibraryTests.exports
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TestA
Loading