[JITLink][AArch64] Add LD64_GOTPAGE_LO15 rel support #100854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yota9
force-pushed
the
jitlink_ld64_gotp_lo15
branch
from
40f1708 to
dc971be
Compare
|
Ping |
lhames
requested changes
Aug 6, 2024
This is looking excellent. Sorry for the delayed review -- I have a couple of small comments, but I think this should be able to land once they're addressed. |
|
Thank you for your review @lhames ! I would try to fix the comments ASAP! |
This relocation is used in order to address GOT entries using 15 bit offset in ldr instruction. The offset is calculated relative to GOT section page address.
yota9
force-pushed
the
jitlink_ld64_gotp_lo15
branch
from
dc971be to
00a67e0
Compare
|
@lhames Thanks for your comments! As for for passing GOTsymbol to applyFixup - I've just copy-pasted x86_64 code for searching GOT symbols (with couple of adjustments) , it seems to be right :) |
lhames
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relocation is used in order to address GOT entries using 15 bit
offset in ldr instruction. The offset is calculated relative to GOT
section page address.