Skip to content

[SandboxIR] Implement CallBrInst #100823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[SandboxIR] Implement CallBrInst #100823

merged 1 commit into from
Jul 29, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Jul 26, 2024

This patch implements sandboxir::CallBrInst which mirrors llvm::CallBrInst.

LLVM IR does not expose the Uses to DefaultDest and IndirectDest so we need special Tracker objects for both of setters.

This patch implements sandboxir::CallBrInst which mirrors llvm::CallBrInst.

LLVM IR does not expose the Uses to DefaultDest and IndirectDest so we need
special Tracker objects for both of setters.
Copy link
Member

@tmsri tmsri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is inline with how other instructions were added.

@vporpo vporpo merged commit cfb92be into llvm:main Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants