[SPIR-V] Switch operands might depends on pointer allocation pattern #94961
Assignees
Labels
Comments
Keenuts
added
bug
|
@llvm/issue-subscribers-bug Author: Nathan Gauër (Keenuts)
By adding https://github.com//pull/92531, I added a new potential source or test flakiness: seems like the order of the switch operands might depend on a SmallPtrSet, hence on memory allocation pattern.
|
This was referenced Jun 10, 2024
Keenuts
added a commit
that referenced
this issue
Jun 11, 2024
The case-list of the switches generated by this pass were not "deterministic" (based on allocation patterns). This is because the CaseList order relied on an unordered_set order. Using the sorted exit target list for those should solve the problem. Fixes #94961 Signed-off-by: Nathan Gauër <[email protected]>
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this issue
Jun 12, 2024
The case-list of the switches generated by this pass were not "deterministic" (based on allocation patterns). This is because the CaseList order relied on an unordered_set order. Using the sorted exit target list for those should solve the problem. Fixes llvm#94961 Signed-off-by: Nathan Gauër <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By adding #92531, I added a new potential source or test flakiness: seems like the order of the switch operands might depend on a SmallPtrSet, hence on memory allocation pattern.
The text was updated successfully, but these errors were encountered: