-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Promotion of bfloat is broken for strictfp functions #78540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@llvm/issue-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm)
https://github.com//pull/74405/commits/b473864900c68c84e37d68f0ea771ef42f13138a
This disabled a test in llvm/test/CodeGen/AMDGPU/llvm.is.fpclass.bf16 because promotion of bf16 fp_round is broken in strictfp functions. We are currently missing strict variants of BF16_TO_FP and FP_TO_BF16 |
I'm working on a patch to add the two variants |
They should get the standard expansions to convert to float |
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
I'm not sure how to move forward with #80056 because I can't design a valid test case. |
We can continue to fail to legalize if we know exceptions are enabled |
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This patch adds the support for `STRICT_BF16_TO_FP` and `STRICT_FP_TO_BF16`. Fix llvm#78540.
This issue has been partially solved by b0c158b. It doesn't hit the assertion now, though we still can't enable those tests because we don't have a valid lowering for AMDGPU. |
b473864
This disabled a test in llvm/test/CodeGen/AMDGPU/llvm.is.fpclass.bf16 because promotion of bf16 fp_round is broken in strictfp functions. We are currently missing strict variants of BF16_TO_FP and FP_TO_BF16
The text was updated successfully, but these errors were encountered: