Skip to content

[Offload] Create a PR to move /openmp/libomptarget to /offload #75124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdoerfert opened this issue Dec 12, 2023 · 2 comments · Fixed by #75125
Closed

[Offload] Create a PR to move /openmp/libomptarget to /offload #75124

jdoerfert opened this issue Dec 12, 2023 · 2 comments · Fixed by #75125
Assignees
@jdoerfert
Labels
offload

Comments

@jdoerfert
Copy link
Member

No description provided.

@jdoerfert jdoerfert self-assigned this Dec 12, 2023
@jdoerfert jdoerfert converted this from a draft issue Dec 12, 2023
@jdoerfert jdoerfert mentioned this issue Dec 12, 2023
Merged
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Dec 12, 2023
@jdoerfert
[Offload][WIP] Move /openmp/libomptarget to /offload
e8b31e1 
** This is still WIP - Testing is needed **

In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been renamed.
The results below are for a build in which OpenMP and Offload are
enabled runtimes. In addition to the pure `git mv`, I needed to adjust
some CMake files. Nothing is intended to change semantics but some of
the things likely broke other build configurations. Testers are needed.

```
ninja -C build/llvm/runtimes/runtimes-bins check-libomptarget
```
Works with the X86 and AMDGPU offload tests

```
ninja -C /build/llvm/ check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.18git`
- `libomptarget.so` -> `libomptarget.so.18git`

Fixes: llvm#75124
@jdoerfert jdoerfert moved this from In progress to In review in LLVM/Offload - Development Dec 13, 2023
@efwright efwright mentioned this issue Feb 21, 2024
Closed
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Mar 15, 2024
@jdoerfert
Move /openmp/libomptarget to /offload
ebde789 
In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been renamed.
The results below are for a build in which OpenMP and Offload are
enabled runtimes. In addition to the pure `git mv`, I needed to adjust
some CMake files. Nothing is intended to change semantics but some of
the things likely broke other build configurations. Testers are needed.

```
ninja -C build/llvm/runtimes/runtimes-bins check-libomptarget
```
Works with the X86 and AMDGPU offload tests

```
ninja -C /build/llvm/ check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Mar 15, 2024
@jdoerfert
Move /openmp/libomptarget to /offload
a63e186 
In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been renamed.
The results below are for a build in which OpenMP and Offload are
enabled runtimes. In addition to the pure `git mv`, I needed to adjust
some CMake files. Nothing is intended to change semantics but some of
the things likely broke other build configurations. Testers are needed.

```
ninja -C build/llvm/runtimes/runtimes-bins check-libomptarget
```
Works with the X86 and AMDGPU offload tests

```
ninja -C /build/llvm/ check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Mar 22, 2024
@jdoerfert
Move /openmp/libomptarget to /offload
b979e39 
In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been renamed.
The results below are for a build in which OpenMP and Offload are
enabled runtimes. In addition to the pure `git mv`, I needed to adjust
some CMake files. Nothing is intended to change semantics but some of
the things likely broke other build configurations. Testers are needed.

```
ninja -C build/llvm/runtimes/runtimes-bins check-libomptarget
```
Works with the X86 and AMDGPU offload tests

```
ninja -C /build/llvm/ check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Apr 4, 2024
@jdoerfert
[Offload] Move /openmp/libomptarget to /offload
af7342a 
With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration. No further changes are
expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure git mv, I needed to adjust
some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Apr 6, 2024
@jdoerfert
[Offload] Move /openmp/libomptarget to /offload
9600535 
With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration. No further changes are
expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure git mv, I needed to adjust
some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Apr 8, 2024
@jdoerfert
[Offload] Move /openmp/libomptarget to /offload
4291503 
With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration. No further changes are
expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure git mv, I needed to adjust
some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
estewart08 pushed a commit to estewart08/llvm-project that referenced this issue Apr 16, 2024
@jdoerfert @estewart08
Move /openmp/libomptarget to /offload
ddf7d08 
With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration. No further changes are
expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure git mv, I needed to adjust
some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
qihangkong pushed a commit to rvgpu/llvm that referenced this issue Apr 18, 2024
@jdoerfert
[Offload][WIP] Move /openmp/libomptarget to /offload
548ebb4 
** This is still WIP - Testing is needed **

In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been renamed.
The results below are for a build in which OpenMP and Offload are
enabled runtimes. In addition to the pure `git mv`, I needed to adjust
some CMake files. Nothing is intended to change semantics but some of
the things likely broke other build configurations. Testers are needed.

```
ninja -C build/llvm/runtimes/runtimes-bins check-libomptarget
```
Works with the X86 and AMDGPU offload tests

```
ninja -C /build/llvm/ check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.18git`
- `libomptarget.so` -> `libomptarget.so.18git`

Fixes: llvm/llvm-project#75124
jdoerfert added a commit to jdoerfert/llvm-project that referenced this issue Apr 18, 2024
@jdoerfert
[Offload] Move /openmp/libomptarget to /offload
e24a5d1 
In a nutshell, this moves our libomptarget code to create the offload
subproject.

With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration. No further changes are
expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure git mv, I needed to adjust
some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.19git`
- `libomptarget.so` -> `libomptarget.so.19git`

Fixes: llvm#75124
jdoerfert added a commit that referenced this issue Apr 22, 2024
@jdoerfert @saiislam
[Offload] Move /openmp/libomptarget to /offload (#75125)
330d898 
In a nutshell, this moves our libomptarget code to populate the offload
subproject.

With this commit, users need to enable the new LLVM/Offload subproject
as a runtime in their cmake configuration.
No further changes are expected for downstream code.

Tests and other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and Offload
are enabled runtimes. In addition to the pure `git mv`, we needed to
adjust some CMake files. Nothing is intended to change semantics.

```
ninja check-offload
```
Works with the X86 and AMDGPU offload tests

```
ninja check-openmp
```
Still works but doesn't build offload tests anymore.

```
ls install/lib
```
Shows all expected libraries, incl.
- `libomptarget.devicertl.a`
- `libomptarget-nvptx-sm_90.bc`
- `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.18git`
- `libomptarget.so` -> `libomptarget.so.18git`

Fixes: #75124

---------

Co-authored-by: Saiyedul Islam <[email protected]>
@github-project-automation github-project-automation bot moved this from In review to Done in LLVM/Offload - Development Apr 22, 2024
searlmc1 pushed a commit to ROCm/llvm-project that referenced this issue Apr 23, 2024
@saiislam @ronlieb
[Offload] Move /openmp/libomptarget to /offload
a8657b1 
Based on PR llvm#75125

In a nutshell, this moves our libomptarget code to create the offload
subproject. For now, we allow LLVM/Offload only as runtime. Tests and
other components still depend on OpenMP and have also not been
renamed. The results below are for a build in which OpenMP and
Offload are enabled runtimes. In addition to the pure git mv, I
needed to adjust some CMake files. Nothing is intended to change
semantics but some of the things likely broke other build
configurations. Testers are needed.

ninja check-offload
Works with the X86 and AMDGPU offload tests

ninja check-openmp
Still works but doesn't build offload tests anymore.

ls install/lib
Shows all expected libraries, incl.

libomptarget.devicertl.a
libomptarget-nvptx-sm_90.bc
libomptarget.rtl.amdgpu.so -> libomptarget.rtl.amdgpu.so.18git
libomptarget.so -> libomptarget.so.18git

Fixes: llvm#75124
Change-Id: Ie1d7a9805309c63292e6378f077ad319b42dd279
@sylvestre
Copy link
Collaborator

FYI, it caused a few regressions:
#90707
#91881
#91819
#90769
#90708

It has been blocking updating apt.llvm.org since it landed

@jhuber6
Copy link
Contributor

jhuber6 commented May 15, 2024

FYI, it caused a few regressions: #90707 #91881 #91819 #90769 #90708

It has been blocking updating apt.llvm.org since it landed

Can you explain how this build worked previously? I was under the impression that i386 was a 32-bit processor and thus not supported by the offloading support. The failures I see in these issues are related to that. What was the working configuration before? I think the solution here is just to make some code that refuses to build libomptarget if the processor is 32-bit most likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdoerfert jdoerfert

Labels
offload
Projects
LLVM/Offload - Development
Status: Done
Milestone
No milestone
4 participants
@sylvestre @jdoerfert @EugeneZelenko @jhuber6