Skip to content

Backport fix for include/__clang_cuda_math.h:39:25: warning: extra tokens at end of #ifdef directive [-Wextra-tokens] in LLVM 17 #64718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joker-eph opened this issue Aug 15, 2023 · 3 comments · Fixed by llvm/llvm-project-release-prs#592
Closed

Backport fix for include/__clang_cuda_math.h:39:25: warning: extra tokens at end of #ifdef directive [-Wextra-tokens] in LLVM 17 #64718

joker-eph opened this issue Aug 15, 2023 · 3 comments · Fixed by llvm/llvm-project-release-prs#592
Labels
clang:headers Headers provided by Clang, e.g. for intrinsics release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@joker-eph
Copy link
Collaborator

c49142e fixed this warning:

include/__clang_cuda_math.h:39:25: warning: extra tokens at end of #ifdef directive [-Wextra-tokens]
```                            ^
@joker-eph joker-eph added this to the LLVM 17.0.X Release milestone Aug 15, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Aug 15, 2023
@joker-eph
Copy link
Collaborator Author

/cherry-pick c49142e

@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2023

/branch llvm/llvm-project-release-prs/issue64718

@EugeneZelenko EugeneZelenko added clang:headers Headers provided by Clang, e.g. for intrinsics release:backport and removed new issue labels Aug 15, 2023
@llvmbot llvmbot mentioned this issue Aug 15, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Aug 15, 2023

/pull-request llvm/llvm-project-release-prs#592

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Aug 16, 2023
@tru tru moved this from Needs Review to Done in LLVM Release Status Aug 16, 2023
bjope added a commit to bjope/llvm-project that referenced this issue Jul 22, 2024
@bjope
[DAGCombiner] Push freeze through SETCC and SELECT_CC (llvm#64718)
8ebe7e6 
Allow pushing freeze through SETCC and SELECT_CC even if there are
multiple "maybe poison" operands. In the past we have limited it to
a single "maybe poison" operand, but it seems profitable to also
allow the multiple operand scenario.

One goal here is to avoid some regressions seen in review of
  llvm#84924
when solving the select->and miscompiles described in
  llvm#84653
yuxuanchen1997 pushed a commit that referenced this issue Jul 25, 2024
@bjope @yuxuanchen1997
[DAGCombiner] Push freeze through SETCC and SELECT_CC (#64718)
6670226 
Summary:
Allow pushing freeze through SETCC and SELECT_CC even if there are
multiple "maybe poison" operands. In the past we have limited it to
a single "maybe poison" operand, but it seems profitable to also
allow the multiple operand scenario.

One goal here is to avoid some regressions seen in review of
  #84924
when solving the select->and miscompiles described in
  #84653

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:headers Headers provided by Clang, e.g. for intrinsics release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#64718 llvm/llvm-project-release-prs
3 participants
@joker-eph @EugeneZelenko @llvmbot