[clang] `SemaOverload` `Qualifiers::isAddressSpaceSupersetOf` called with wrong order of arguments

[HoBoIs]

in clang/lib/Sema/SemaOverload.cpp clang::isBetterOverloadCandidate line 10243,10245 Qualifiers::isAddressSpaceSupersetOf is called with the same arguments (AS2, AS1), making the 2nd call unnecessary. I think the order of the parameters are meant to be swapped in one of them (I think in the 2nd one). This can lead to a future bug if Qualifiers::isAddressSpaceSupersetOf (AS1,AS2) is true and an other check is added later after line 10248.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

[HoBoIs]

@OleStrohm @AnastasiaStulova #49673

[AnastasiaStulova]

Good spot! I agree that the second if statement with isAddressSpaceSupersetOf is incorrect and the address spaces should be swapped there indeed.

Fee free to create PR and I am happy to help reviewing. Maybe the OpenCL example from the bug you have linked here could be used as a test case.