Expression end location not working in macros

[abrachet]

#define MACRO(var) {var}

char ok(int a) {
    return {a}; // static_cast<char>( )
}

char macro(int a) {
    return MACRO(a); // static_cast<char>(
    // note the lack of end `)`
}

This fixit is issued here

llvm-project/clang/lib/Sema/SemaInit.cpp

Line 10366 in 7175d6a

<< FixItHint::CreateInsertion(

and uses FixItHint::CreateInsertion(S.getLocForEndOfToken(PostInit->getEndLoc()), ")"); to emit the insertion for the end paren. It is just missing in the fixit hint.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

[smeenai]

/cherry-pick 61c5ad8

[llvmbot]

/branch llvm/llvm-project-release-prs/issue63462

[llvmbot]

/pull-request llvm/llvm-project-release-prs#704