[clang-16.0.0rc3][include-cleaner] invalid operands to binary expression

[fafryd1125]

[1726/2086] Building CXX object tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o
FAILED: tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o
/usr/bin/clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/clang/src/clang-16.0.0rc3.src/build/tools/extra/include-cleaner/unittests -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests -I/build/clang/src/clang-16.0.0rc3.src/include -I/build/clang/src/clang-16.0.0rc3.src/build/include -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/include -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/../lib -fdiagnostics-color -march=native -O3 -pipe -fstack-protector-strong -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -pedantic -Wno-long-long -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -std=c++17 -MD -MT tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o -MF tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o.d -o tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/AnalysisTest.cpp.o -c /build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/AnalysisTest.cpp
In file included from /build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/AnalysisTest.cpp:24:
In file included from /usr/include/gmock/gmock.h:56:
In file included from /usr/include/gmock/gmock-actions.h:145:
In file included from /usr/include/gmock/internal/gmock-internal-utils.h:50:
In file included from /usr/include/gtest/gtest.h:64:
In file included from /usr/include/gtest/gtest-assertion-result.h:46:
/usr/include/gtest/gtest-message.h:132:10: error: invalid operands to binary expression ('std::basic_stringstream<char>' and 'const llvm::StringRef')
    *ss_ << val;
    ~~~~ ^  ~~~

[1729/2086] Building CXX object tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o
FAILED: tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o
/usr/bin/clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/clang/src/clang-16.0.0rc3.src/build/tools/extra/include-cleaner/unittests -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests -I/build/clang/src/clang-16.0.0rc3.src/include -I/build/clang/src/clang-16.0.0rc3.src/build/include -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/include -I/build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/../lib -fdiagnostics-color -march=native -O3 -pipe -fstack-protector-strong -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -pedantic -Wno-long-long -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -std=c++17 -MD -MT tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o -MF tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o.d -o tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o -c /build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/LocateSymbolTest.cpp
In file included from /build/clang/src/clang-tools-extra-16.0.0rc3.src/include-cleaner/unittests/LocateSymbolTest.cpp:20:
In file included from /usr/include/gmock/gmock.h:56:
In file included from /usr/include/gmock/gmock-actions.h:145:
In file included from /usr/include/gmock/internal/gmock-internal-utils.h:50:
In file included from /usr/include/gtest/gtest.h:64:
In file included from /usr/include/gtest/gtest-assertion-result.h:46:
/usr/include/gtest/gtest-message.h:132:10: error: invalid operands to binary expression ('std::basic_stringstream<char>' and 'const llvm::StringRef')
    *ss_ << val;
    ~~~~ ^  ~~~

An error only occurs in clang-16.0.0rc3 standalone build

[llvmbot]

@llvm/issue-subscribers-clang-include-cleaner

[hokein]

This was fixed in main branch, 48027f0.

We need a cherry pick for it. Filed at #61239.

[fafryd1125]

7ceeae3 still doesn't help
clang-16.0.0rc4 (not full log):

[1720/2086] Building CXX object tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/Types.cpp.o
[1721/2086] Building CXX object tools/extra/clang-query/tool/CMakeFiles/clang-query.dir/ClangQuery.cpp.o
[1722/2086] Linking CXX executable bin/clang-query
[1723/2086] Building CXX object tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/HTMLReport.cpp.o
[1724/2086] Building CXX object tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/Record.cpp.o
[1725/2086] Building CXX object tools/extra/include-cleaner/tool/CMakeFiles/clang-include-cleaner.dir/IncludeCleaner.cpp.o
[1726/2086] Building CXX object tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o
FAILED: tools/extra/include-cleaner/unittests/CMakeFiles/ClangIncludeCleanerTests.dir/LocateSymbolTest.cpp.o.
/usr/bin/clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/clang/src/clang-16.0.0rc4.src/build/tools/extra/include-cleaner/unittests -I/build/clang/src/clang-tools-extra-16.0.0rc4.src/include-cleaner/unittests -I/build/clang/src/clang-
In file included from /build/clang/src/clang-tools-extra-16.0.0rc4.src/include-cleaner/unittests/LocateSymbolTest.cpp:20:
In file included from /usr/include/gmock/gmock.h:56:
In file included from /usr/include/gmock/gmock-actions.h:145:
In file included from /usr/include/gmock/internal/gmock-internal-utils.h:50:
In file included from /usr/include/gtest/gtest.h:64:
In file included from /usr/include/gtest/gtest-assertion-result.h:46:
/usr/include/gtest/gtest-message.h:132:10: error: invalid operands to binary expression ('std::basic_stringstream<char>' and 'const llvm::StringRef')
    *ss_ << val;
    ~~~~ ^  ~~~
/build/clang/src/clang-tools-extra-16.0.0rc4.src/include-cleaner/unittests/LocateSymbolTest.cpp:69:48: note: in instantiation of function template specialization 'testing::Message::operator<<<llvm::StringRef>' requested here
              << "Found multiple matches for " << NameToFind;
                                               ^

[kadircet]

@fafryd1125 that's a new one, should be fixed with 9b5a934
but needs to be cherry-picked again

[kadircet]

@fafryd1125 actually you seem to be building LLVM with a system installed gtest, includes are coming from /usr/include (thanks to @sam-mccall for pointing this out).

I couldn't find any references to it, but building LLVM with an external gtest should be unsupported, as we've many customizations to it (see for example 2fe9ce6).

So I won't issue a cherry-pick of this one, you should get your include paths fixed to use gtest from llvm repository instead.

[fafryd1125]

@fafryd1125 actually you seem to be building LLVM with a system installed gtest, includes are coming from /usr/include (thanks to @sam-mccall for pointing this out).

After adding third-party sub-directorie, I finally build clang-16.0.0rc4

I couldn't find any references to it, but building LLVM with an external gtest should be unsupported, as we've many customizations to it (see for example 2fe9ce6).

I think it's worth mentioning here https://llvm.org/docs/GettingStarted.html#stand-alone-builds

@kadircet Thank you for your help