Skip to content

[mlir][tablegen] getCPPClassName called on a mlir::pdl::OperationType returns unqualified type #57279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ralender opened this issue Aug 22, 2022 · 1 comment · Fixed by #102657
Closed

[mlir][tablegen] getCPPClassName called on a mlir::pdl::OperationType returns unqualified type #57279

Ralender opened this issue Aug 22, 2022 · 1 comment · Fixed by #102657
Labels
mlir tablegen

Comments

@Ralender
Copy link
Collaborator

Ralender commented Aug 22, 2022 •
edited
Loading

inside tablegen, calling getCPPClassName on a TypeConstraint representing mlir::pdl::OperationType will return the unqualified type OperationType instead of a fully qualified ::mlir::pdl::OperationType

see https://reviews.llvm.org/D132010#inline-1271473 for details.

more generally I think tablegen should emit an error if it cannot figure out a fully qualified type for anything.
@llvmbot
Copy link
Member

llvmbot commented Aug 22, 2022

@llvm/issue-subscribers-mlir

@matthias-springer matthias-springer mentioned this issue Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mlir tablegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mlir][ODS] Consistent cppType / cppClassName usage llvm/llvm-project
3 participants
@EugeneZelenko @Ralender @llvmbot