Merge r360405 into 8.0

[adalava]

Bugzilla Link	41959
Resolution	FIXED
Resolved on	May 31, 2019 15:51
Version	unspecified
OS	FreeBSD
Blocks	#40566
CC	@hfinkel,@MaskRay,@luporl,@smithp35,@tstellar
Fixed by commit(s)	r353865 r353866 358975 r360405 r362043 r362273 r362274

Extended Description

This fixes #40086 by implementing getThunkSectionSpacing() on PowerPC64. Without this, start section of large binaries linked with lld gets corrupted on FreeBSD.

This is part of the set of fixes needed to change FreeBSD system compiler to clang8, on PowerPC.

[adalava]

assigned to @rui314

[tstellar]

Hi Rui,

Is this OK to merge?

https://reviews.llvm.org/rL360405

[MaskRay]

Given the reply llvm/llvm-bugzilla-archive#41943 #c3 , I'm in favor of merging this. I believe lld's PPC port is in a good status now (it wasn't in the 7.* release). It'd be great to make it easy for downstream users (specifically, FreeBSD folks who want to test it. Thanks!) to check its status.

[rui314]

Yes, it is OK to merge this patch. It is not exactly a bug fix patch, but implements a function to work things correctly, and at least this shouldn't affect non-PPC64 targets.

[tstellar]

It looks like some of the test changes in this commit depend on some other ppc64 fixes. Would it be Ok to merge these fixes too:

https://reviews.llvm.org/rL353865
https://reviews.llvm.org/rL353866

[hfinkel]

It looks like some of the test changes in this commit depend on some other
ppc64 fixes. Would it be Ok to merge these fixes too:

https://reviews.llvm.org/rL353865
https://reviews.llvm.org/rL353866

Yes, those should be okay to merge as well.

[tstellar]

Rui, Fangrui,

Could we merge this lld commit: https://reviews.llvm.org/rL358975 too? This will help reduce a number of merge conflicts in the ppc64 tests.

[MaskRay]

rL358975 should be ok. It is a pure test change.

[rui314]

I agree with Fangrui.

[tstellar]

Merged: r362043 r362273 r362274