Skip to content

[AMDGPU][MC] Many MIMG opcodes do not accept tfe with dmask:0xf #38648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpreobra opened this issue Oct 15, 2018 · 4 comments
Closed

[AMDGPU][MC] Many MIMG opcodes do not accept tfe with dmask:0xf #38648

dpreobra opened this issue Oct 15, 2018 · 4 comments
Assignees
Labels
backend:AMDGPU bugzilla Issues migrated from bugzilla

Comments

@dpreobra
Copy link
Collaborator

Bugzilla Link 39300
Version trunk
OS All
CC @atamazov,@jayfoad,@arsenm

Extended Description

The reason for this issue is that current implementation does not support 5-register tuples.

@jayfoad
Copy link
Contributor

jayfoad commented Jan 20, 2021

I think this is fixed now. See https://reviews.llvm.org/D94960 which enabled proper disassembly of MIMG instructions with tfe.

@dpreobra
Copy link
Collaborator Author

Thanks! The patch you mentioned did fix a lot of disassembler failures.

However some tests with 0xf dmask still fail to disassemble.

For example, the following code is disassembled ok for gfx8 and gfx9:

0x00,0x0f,0x44,0xf0,0xfc,0x05,0x02,0x00
image_atomic_cmpswap v[5:8], v252, s[8:15] dmask:0xf

The same code with tfe produces an invalid output for the same GPUs:

0x00,0x0f,0x45,0xf0,0xfc,0x05,0x02,0x00
image_atomic_cmpswap v[5:6], v252, s[8:15] dmask:0xf tfe

Also the following instruction fails to assemble on gfx7-gfx10:

image_atomic_cmpswap v[5:9], v252, s[8:15] dmask:0xf tfe

See also related bugs 48846, 48847

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@jwanggit86 jwanggit86 self-assigned this Nov 14, 2024
@jwanggit86
Copy link
Contributor

I think this problem is now fixed with PR 112622.

@arsenm
Copy link
Contributor

arsenm commented Nov 15, 2024

Seems to work now

@arsenm arsenm closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AMDGPU bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

4 participants