advapi.lib missing from llvm-config.exe --system-libs on windows

[andrewrk]

Bugzilla Link	36372
Resolution	FIXED
Resolved on	Feb 23, 2018 04:23
Version	6.0
OS	other
Blocks	#35152
CC	@zmodem,@rnk

Extended Description

"c:\Users\andy\llvm+clang-6.0.0rc2-win64-msvc-release\bin\llvm-config.exe" --system-libs
psapi.lib shell32.lib ole32.lib uuid.lib

But then when I link against LLVM and these libs, I get:

lld: error: LLVMSupport.lib(Process.obj): undefined symbol:
__imp_CryptAcquireContextW
lld: error: LLVMSupport.lib(RandomNumberGenerator.obj): undefined
symbol: __imp_CryptAcquireContextW
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegCloseKey
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegOpenKeyExA
lld: error: LLVMSupport.lib(Signals.obj): undefined symbol: __imp_RegGetValueW

It seems that Advapi32.lib is missing from the --system-libs list.

I manually added advapi32.lib to my linker line and the build succeeded.

[rnk]

Why doesn't our #pragma comment lib work?
$ git grep -i advapi32 ../llvm ../llvm/lib/Support/Windows/Path.inc:# pragma comment(lib, "advapi32.lib") // This provides CryptAcquireContextW.

[zmodem]

I'm not sure this is a release blocker?

[andrewrk]

http://lists.llvm.org/pipermail/llvm-dev/2018-February/121204.html

[zmodem]

I suppose this is easy to fix.

r325894 and merged to 6.0 in r325895.

Andrew, please reopen if there are still problems here.