[ARM] -Wtautological-type-limit-compare in libcxx and libcxxabi tests

[rovka]

Bugzilla Link	35997
Resolution	DUPLICATE
Resolved on	Jan 18, 2018 06:43
Version	6.0
OS	Linux
Blocks	#35152
CC	@zmodem,@LebedevRI,@mclow

Extended Description

I'm getting ~1160 test failures in libcxx and libcxxabi while testing the 6.0.0 release on ARM. They all seem to be something like this:

******************** TEST 'libc++ :: std/utilities/utility/pairs/pair.astuple/pairs.by.type.pass.cpp' FAILED ********************
Command: ['/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/bin/clang++', '-o', '/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/Output/pairs.by.type.pass.cpp.o', '-x', 'c++', '/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/pairs.by.type.pass.cpp', '-c', '-v', '-D_LIBCPP_DISABLE_AVAILABILITY', '-ftemplate-depth=270', '-Werror=thread-safety', '-std=c++2a', '-include', '/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support/nasty_macros.hpp', '-nostdinc++', '-I/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include', '-I/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/include/c++build', '-D__STDC_FORMAT_MACROS', '-D__STDC_LIMIT_MACROS', '-D__STDC_CONSTANT_MACROS', '-I/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/std/experimental/filesystem/Inputs/static_test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/filesystem/Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/usr/bin/python2.7 /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support/filesystem_dynamic_test_helper.py"', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wno-aligned-allocation-unavailable', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-conversion', '-Wno-unused-local-typedef', '-Wno-#warnings', '-c']
Exit Code: 1
Standard Error:

clang version 6.0.0 (tags/RELEASE_600/rc1)
Target: armv7l-unknown-linux-gnueabihf
Thread model: posix
InstalledDir: /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/bin
Found candidate GCC installation: /usr/lib/gcc/arm-linux-gnueabihf/5
Found candidate GCC installation: /usr/lib/gcc/arm-linux-gnueabihf/5.4.0
Found candidate GCC installation: /usr/lib/gcc/arm-linux-gnueabihf/6
Found candidate GCC installation: /usr/lib/gcc/arm-linux-gnueabihf/6.0.0
Selected GCC installation: /usr/lib/gcc/arm-linux-gnueabihf/5.4.0
Candidate multilib: .;@m32
Selected multilib: .;@m32
"/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/bin/clang-6.0" -cc1 -triple armv7-unknown-linux-gnueabihf -emit-obj -mrelax-all -disable-free -disable-llvm-verifier -discard-value-names -main-file-name pairs.by.type.pass.cpp -mrelocation-model static -mthread-model posix -mdisable-fp-elim -fmath-errno -masm-verbose -mconstructor-aliases -fuse-init-array -target-cpu generic -target-abi aapcs-linux -mfloat-abi hard -fallow-half-arguments-and-returns -dwarf-column-info -debugger-tuning=gdb -v -coverage-notes-file /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/Output/pairs.by.type.pass.cpp.gcno -nostdinc++ -resource-dir /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/lib/clang/6.0.0 -include /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support/nasty_macros.hpp -D _LIBCPP_DISABLE_AVAILABILITY -I /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include -I /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/include/c++build -D __STDC_FORMAT_MACROS -D __STDC_LIMIT_MACROS -D __STDC_CONSTANT_MACROS -I /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support -D "LIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/std/experimental/filesystem/Inputs/static_test_env"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/filesystem/Output/dynamic_env"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/usr/bin/python2.7 /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support/filesystem_dynamic_test_helper.py"" -D _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -internal-isystem /usr/local/include -internal-isystem /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/lib/clang/6.0.0/include -internal-externc-isystem /usr/include/arm-linux-gnueabihf -internal-externc-isystem /include -internal-externc-isystem /usr/include -Werror=thread-safety -Wall -Wextra -Werror -Wuser-defined-warnings -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-aligned-allocation-unavailable -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-conversion -Wno-unused-local-typedef -Wno-#warnings -std=c++2a -fdeprecated-macro -fdebug-compilation-dir /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple -ftemplate-depth 270 -ferror-limit 19 -fmessage-length 0 -fno-signed-char -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -o /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/Output/pairs.by.type.pass.cpp.o -x c++ /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/pairs.by.type.pass.cpp
clang -cc1 version 6.0.0 based upon LLVM 6.0.0 default target armv7l-unknown-linux-gnueabihf
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase3/Release/llvmCore-6.0.0-rc1.obj/projects/libcxx/include/c++build
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/support
/usr/local/include
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/Phase2/Release/llvmCore-6.0.0-rc1.install/usr/local/lib/clang/6.0.0/include
/usr/include/arm-linux-gnueabihf
/usr/include
End of search list.
In file included from /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/test/std/utilities/utility/pairs/pair.astuple/pairs.by.type.pass.cpp:15:
In file included from /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include/complex:247:
In file included from /home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include/sstream:175:
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include/istream:714:24: error: result of comparison 'long' < -2147483648 is always false [-Werror,-Wtautological-type-limit-compare]
if (__temp < numeric_limits::min())
~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/workspace/tcwg-llvm-release/tcwg-tk1_32-build/rc1/llvm.src/projects/libcxx/include/istream:719:29: error: result of comparison 'long' > 2147483647 is always false [-Werror,-Wtautological-type-limit-compare]
else if (__temp > numeric_limits::max())
~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

Compilation failed unexpectedly!

---

[rovka]

assigned to @mclow

[mclow]

Short answer: turn off '-Wtautological-type-limit-compare'.

Long answer soon.

[mclow]

*** This bug has been marked as a duplicate of bug #35046 ***

[zmodem]

Short answer: turn off '-Wtautological-type-limit-compare'.

Long answer soon.

I believe (Diana can confirm) that this build is done with utils/release/test-release.sh and is using the default flags configured by the cmake files.

[LebedevRI]

I believe (Diana can confirm) that this build is done with utils/release/test-release.sh and is using the default flags configured by the cmake files.

See https://reviews.llvm.org/D41727

[rovka]

Short answer: turn off '-Wtautological-type-limit-compare'.

Long answer soon.

I believe (Diana can confirm) that this build is done with
utils/release/test-release.sh and is using the default flags configured by
the cmake files.

Yep.