Invalid InsertValueInst operands!

[stbergmann]

Bugzilla Link	35777
Resolution	FIXED
Resolved on	Jan 17, 2018 08:04
Version	trunk
OS	Linux
Blocks	#35152
CC	@alexey-bataev,@dtemirbulatov,@zmodem,@RKSimon
Fixed by commit(s)	321994

Extended Description

At least with recent trunk towards 6.0 built with -DLLVM_ENABLE_ASSERTIONS=ON I get the following error:

$ cat test.cc
struct S {
long a, b;
S(long x, long y): a(x), b(y) {}
};
double a[6];
S f(double y) { return S(int(a[0] + ya[2] + a[4]), int(a[1] + ya[3] + a[5])); }

$ clang++ -O2 -c test.cc -v
clang version 6.0.0
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/sbergman/llvm/inst/bin
Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/7
Selected GCC installation: /usr/lib/gcc/x86_64-redhat-linux/7
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64
"/home/sbergman/llvm/inst/bin/clang-6.0" -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -disable-free -main-file-name test.cc -mrelocation-model static -mthread-model posix -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -dwarf-column-info -debugger-tuning=gdb -momit-leaf-frame-pointer -v -coverage-notes-file /home/sbergman/lo2/core/test.gcno -resource-dir /home/sbergman/llvm/inst/lib/clang/6.0.0 -internal-isystem /usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7 -internal-isystem /usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/x86_64-redhat-linux -internal-isystem /usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/backward -internal-isystem /usr/local/include -internal-isystem /home/sbergman/llvm/inst/lib/clang/6.0.0/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -O2 -fdeprecated-macro -fdebug-compilation-dir /home/sbergman/lo2/core -ferror-limit 19 -fmessage-length 113 -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -vectorize-loops -vectorize-slp -o test.o -x c++ test.cc
clang -cc1 version 6.0.0 based upon LLVM 6.0.0svn default target x86_64-unknown-linux-gnu
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7
/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/x86_64-redhat-linux
/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/backward
/usr/local/include
/home/sbergman/llvm/inst/lib/clang/6.0.0/include
/usr/include
End of search list.
Invalid InsertValueInst operands!
%.fca.0.insert = insertvalue { i64, i64 } undef, i32 %9, 0
Invalid InsertValueInst operands!
%.fca.1.insert = insertvalue { i64, i64 } %.fca.0.insert, i32 %10, 1
fatal error: error in backend: Broken function found, compilation aborted!
clang-6.0: error: clang frontend command failed with exit code 70 (use -v to see invocation)
clang version 6.0.0
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/sbergman/llvm/inst/bin
clang-6.0: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and associated run script.
clang-6.0: note: diagnostic msg:

---

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-6.0: note: diagnostic msg: /tmp/test-bd3d95.cpp
clang-6.0: note: diagnostic msg: /tmp/test-bd3d95.sh
clang-6.0: note: diagnostic msg:

---

[stbergmann]

assigned to @alexey-bataev

[RKSimon]

I haven't been able to reproduce this - please can you post the IR?

[stbergmann]

$ clang++ -O2 -S -emit-llvm test.cc
; ModuleID = 'test.cc'
source_filename = "test.cc"
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

@​a = local_unnamed_addr global [6 x double] zeroinitializer, align 16

; Function Attrs: norecurse nounwind readonly uwtable
define { i64, i64 } @​_Z1fd(double %y) local_unnamed_addr #​0 {
entry:
%0 = load <2 x double>, <2 x double>* bitcast ([6 x double]* @​a to <2 x double>), align 16, !tbaa !​2
%1 = load <2 x double>, <2 x double> bitcast (double* getelementptr inbounds ([6 x double], [6 x double]* @​a, i64 0, i64 2) to <2 x double>), align 16, !tbaa !​2
%2 = insertelement <2 x double> undef, double %y, i32 0
%3 = shufflevector <2 x double> %2, <2 x double> undef, <2 x i32> zeroinitializer
%4 = fmul <2 x double> %3, %1
%5 = fadd <2 x double> %0, %4
%6 = load <2 x double>, <2 x double> bitcast (double* getelementptr inbounds ([6 x double], [6 x double]* @​a, i64 0, i64 4) to <2 x double>*), align 16, !tbaa !​2
%7 = fadd <2 x double> %6, %5
%8 = fptosi <2 x double> %7 to <2 x i32>
%9 = extractelement <2 x i32> %8, i32 0
%10 = extractelement <2 x i32> %8, i32 1
%.fca.0.insert = insertvalue { i64, i64 } undef, i32 %9, 0
%.fca.1.insert = insertvalue { i64, i64 } %.fca.0.insert, i32 %10, 1
ret { i64, i64 } %.fca.1.insert
}

attributes #​0 = { norecurse nounwind readonly uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }

!llvm.module.flags = !{#0}
!llvm.ident = !{#1}

!​0 = !{i32 1, !"wchar_size", i32 4}
!​1 = !{!"clang version 6.0.0 "}
!​2 = !{#3, !​3, i64 0}
!​3 = !{!"double", !​4, i64 0}
!​4 = !{!"omnipotent char", !​5, i64 0}
!​5 = !{!"Simple C++ TBAA"}

[llvmbot]

It's the SLPvectorizer

$ ./opt meh.ll -verify -slp-vectorizer -o /dev/null
Invalid InsertValueInst operands!
%.fca.0.insert = insertvalue { i64, i64 } undef, i32 %11, 0
Invalid InsertValueInst operands!
%.fca.1.insert = insertvalue { i64, i64 } %.fca.0.insert, i32 %13, 1
LLVM ERROR: Broken function found, compilation aborted!
$ ./opt meh.ll -verify -o /dev/null
$

Reducing now.

[llvmbot]

Reduced:

target triple = "x86_64-apple-macosx10.13.0"

@​global = local_unnamed_addr global [6 x double] zeroinitializer, align 16

define { i64, i64 } @​patatino(double %arg) {
bb:
%tmp = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 0), align 16
%tmp1 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 2), align 16
%tmp2 = fmul double %tmp1, %arg
%tmp3 = fadd double %tmp, %tmp2
%tmp4 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 4), align 16
%tmp5 = fadd double %tmp4, %tmp3
%tmp6 = fptosi double %tmp5 to i32
%tmp7 = sext i32 %tmp6 to i64
%tmp8 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 1), align 8
%tmp9 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 3), align 8
%tmp10 = fmul double %tmp9, %arg
%tmp11 = fadd double %tmp8, %tmp10
%tmp12 = load double, double* getelementptr inbounds ([6 x double], [6 x double]* @​global, i64 0, i64 5), align 8
%tmp13 = fadd double %tmp12, %tmp11
%tmp14 = fptosi double %tmp13 to i32
%tmp15 = sext i32 %tmp14 to i64
%tmp16 = insertvalue { i64, i64 } undef, i64 %tmp7, 0
%tmp17 = insertvalue { i64, i64 } %tmp16, i64 %tmp15, 1
ret { i64, i64 } %tmp17
}

[alexey-bataev]

Caused by https://reviews.llvm.org/rL320736, working on fix

[alexey-bataev]

Fixed in rL321994

[RKSimon]

Reopening until its merged into the 6.00 release branch

[zmodem]

Merged to 6.0 in r322675.

[zmodem]

mentioned in issue #35152