Please backport clang python binding fixes to release_50 #33734
Description
| Bugzilla Link | 34386 |
| Resolution | FIXED |
| Resolved on | Sep 28, 2017 10:23 |
| Version | trunk |
| OS | Linux |
| Blocks | #33840 |
| Reporter | LLVM Bugzilla Contributor |
| CC | @zmodem,@tstellar |
| Fixed by commit(s) | r312622 r314434 |
Extended Description
Please revert the following commit from the 5.0 release branch:
commit 34efc84dff3e2cb91e6afdf460a7893a4a886029
Author: Jonathan Coe [email protected]
Date: Wed Jun 28 00:54:56 2017
[libclang] Support for querying the exception specification type through libclang
Summary: This patch exposes the exception specification type (noexcept,
etc.) of a C++ function through libclang and Python clang.cindex.
Reviewers: rsmith, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: jbcoe, cfe-commits
Differential Revision: https://reviews.llvm.org/D34091
Patch by Andrew Bennieston
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@306483 91177308-0d34-0410-b5e6-96231b3b80d8
The committed change references an utility module that's missing (it hasn't been committed with the change or included in the differential revision). I've left a comment on D34091 over a month ago and received no reply.
This incomplete commit causes a test suite failure:
Failure: ImportError (No module named 'tests.util') ... ERROR
======================================================================
ERROR: Failure: ImportError (No module named 'tests.util')
Traceback (most recent call last):
File "/usr/lib64/python3.5/site-packages/nose/failure.py", line 39, in runTest
raise self.exc_val.with_traceback(self.tb)
File "/usr/lib64/python3.5/site-packages/nose/loader.py", line 419, in loadTestsFromName
addr.filename, addr.module)
File "/usr/lib64/python3.5/site-packages/nose/importer.py", line 47, in importFromPath
return self.importFromDir(dir_path, fqname)
File "/usr/lib64/python3.5/site-packages/nose/importer.py", line 94, in importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File "/usr/lib64/python3.5/imp.py", line 234, in load_module
return load_source(name, filename, file)
File "/usr/lib64/python3.5/imp.py", line 172, in load_source
module = _load(spec)
File "", line 693, in _load
File "", line 673, in _load_unlocked
File "", line 673, in exec_module
File "", line 222, in _call_with_frames_removed
File "/usr/src/llvm/tools/clang/bindings/python/tests/test_exception_specification_kind.py", line 3, in
from .util import get_tu
ImportError: No module named 'tests.util'
Ran 111 tests in 2.182s
FAILED (errors=1)