libclang abort death test fails when run as part of AllClangUnitTests binary #137855
Labels
Comments
rnk
added a commit
that referenced
this issue
Apr 29, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue #137855 for the investigation.
EugeneZelenko
added
test-suite
clang:as-a-library
|
cc @jkorous-apple , who added the test |
rnk
added a commit
to rnk/llvm-project
that referenced
this issue
Apr 30, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue llvm#137855 for the investigation.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue llvm#137855 for the investigation.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue llvm#137855 for the investigation.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this issue
May 6, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this issue
May 7, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue llvm#137855 for the investigation.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this issue
May 7, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this issue
May 9, 2025
Death tests are often sensitive to global process state, which is dirtier now that the scope of the test binary has increased significantly. I think the value of this single death test isn't high enough to roll back the gtest binary merging patch, so I'm disabling it. See issue llvm#137855 for the investigation.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this issue
May 9, 2025
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After PR #134196 , a few buildbots reported that the LibclangParseTest.UninstallAbortingLLVMFatalErrorHandler test fails on Mac bots:
https://lab.llvm.org/buildbot/#/builders/23/builds/9847
https://lab.llvm.org/buildbot/#/builders/190/builds/19202
I plan to disable this specific test rather than rolling back, and I'm filing this issue to track fixing the test.
The text was updated successfully, but these errors were encountered: