[clang] Shard out some small gtest binaries

rnk · rnk · commit 6327f1cdae00 · 2025-04-30T13:14:44.000-07:00
@nico mentioned that FormatTests and BasicTests are small binaries with few dependencies, so keeping them separate is nice. I broke them out as distinct test binaries, and they are still pretty small: $ find tools/clang/unittests/ -type f -name '*Tests' | xargs du -cksh | sort -nr 708M total 276M tools/clang/unittests/AllClangUnitTests 244M tools/clang/unittests/Interpreter/ClangReplInterpreterTests 167M tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests 13M tools/clang/unittests/Format/FormatTests 6.9M tools/clang/unittests/Basic/BasicTests 1.1M tools/clang/unittests/libclang/CrashTests/libclangCrashTests I also broke out libclangCrashTests and re-enabled the failing test to resolve llvm#137855.
diff --git a/clang/unittests/Basic/CMakeLists.txt b/clang/unittests/Basic/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_clang_unittest(BasicTests
+add_distinct_clang_unittest(BasicTests
   CharInfoTest.cpp
   DarwinSDKInfoTest.cpp
   DiagnosticTest.cpp
diff --git a/clang/unittests/Format/CMakeLists.txt b/clang/unittests/Format/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_clang_unittest(FormatTests
+add_distinct_clang_unittest(FormatTests
   BracesInserterTest.cpp
   BracesRemoverTest.cpp
   CleanupTest.cpp
diff --git a/clang/unittests/libclang/CrashTests/CMakeLists.txt b/clang/unittests/libclang/CrashTests/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_clang_unittest(libclangCrashTests
+add_distinct_clang_unittest(libclangCrashTests
   LibclangCrashTest.cpp
   LINK_LIBS
   libclang
diff --git a/clang/unittests/libclang/CrashTests/LibclangCrashTest.cpp b/clang/unittests/libclang/CrashTests/LibclangCrashTest.cpp
@@ -23,8 +23,7 @@ TEST_F(LibclangParseTest, InstallAbortingLLVMFatalErrorHandler) {
                "");
 }
 
-// FIXME: Re-enable after Mac-AArch64 signpost crash issues are debugged.
-TEST_F(LibclangParseTest, DISABLED_UninstallAbortingLLVMFatalErrorHandler) {
+TEST_F(LibclangParseTest, UninstallAbortingLLVMFatalErrorHandler) {
   clang_toggleCrashRecovery(0);
   clang_install_aborting_llvm_fatal_error_handler();
   clang_uninstall_llvm_fatal_error_handler();

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-add_clang_unittest(BasicTests`
	`1`	`+add_distinct_clang_unittest(BasicTests`
`2`	`2`	`CharInfoTest.cpp`
`3`	`3`	`DarwinSDKInfoTest.cpp`
`4`	`4`	`DiagnosticTest.cpp`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-add_clang_unittest(FormatTests`
	`1`	`+add_distinct_clang_unittest(FormatTests`
`2`	`2`	`BracesInserterTest.cpp`
`3`	`3`	`BracesRemoverTest.cpp`
`4`	`4`	`CleanupTest.cpp`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-add_clang_unittest(libclangCrashTests`
	`1`	`+add_distinct_clang_unittest(libclangCrashTests`
`2`	`2`	`LibclangCrashTest.cpp`
`3`	`3`	`LINK_LIBS`
`4`	`4`	`libclang`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,7 @@ TEST_F(LibclangParseTest, InstallAbortingLLVMFatalErrorHandler) {`
`23`	`23`	`"");`
`24`	`24`	`}`
`25`	`25`
`26`		`-// FIXME: Re-enable after Mac-AArch64 signpost crash issues are debugged.`
`27`		`-TEST_F(LibclangParseTest, DISABLED_UninstallAbortingLLVMFatalErrorHandler) {`
	`26`	`+TEST_F(LibclangParseTest, UninstallAbortingLLVMFatalErrorHandler) {`
`28`	`27`	`clang_toggleCrashRecovery(0);`
`29`	`28`	`clang_install_aborting_llvm_fatal_error_handler();`
`30`	`29`	`clang_uninstall_llvm_fatal_error_handler();`