Skip to content

Request Commit Access For sebpop #123001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebpop opened this issue Jan 15, 2025 · 10 comments
Closed

Request Commit Access For sebpop #123001

sebpop opened this issue Jan 15, 2025 · 10 comments

Comments

@sebpop
Copy link
Contributor

sebpop commented Jan 15, 2025

I am requesting commit access to be able to merge my own approved patches: #116628 #116631

I am fixing the data dependence analysis and working on the loop optimizers.

@llvmbot
Copy link
Member

llvmbot commented Jan 15, 2025

@llvm/issue-subscribers-infra-commit-access-request

Author: Sebastian Pop (sebpop)

I am requesting commit access to be able to merge my own approved patches: https://github.com//pull/116628 https://github.com//pull/116631

I am fixing the data dependence analysis and working on the loop optimizers.

@sebpop
Copy link
Contributor Author

sebpop commented Jan 22, 2025

Ping, could you please grant me commit access?
I had access to commit my own patches for the past 10+ years:

~/llvm-project $ git log | grep '^Author:' | grep 'Sebastian Pop' | wc -l
236

@asl
Copy link
Collaborator

asl commented Jan 22, 2025

@sebpop What happened with your previous commit access?

@tstellar
Copy link
Collaborator

Activity Summary:

@sebpop
Copy link
Contributor Author

sebpop commented Jan 23, 2025

What happened with your previous commit access?

I had github access approved by Chris sometime in 2020 or so after the move to github. Then the github merge access got disabled for some reason in 2024, maybe because I changed employers? I asked Chris about re-enabling merge, and it seems like the merge rules have changed. So here I am following what the web page says to request merge access.

@asl
Copy link
Collaborator

asl commented Jan 23, 2025

Then the github merge access got disabled for some reason in 2024, maybe because I changed employers?

No. It was due to inactivity. It was disabled in #86324

@sebpop
Copy link
Contributor Author

sebpop commented Jan 24, 2025

Can you please flip back the switch?
Thanks!

@sebpop
Copy link
Contributor Author

sebpop commented Jan 28, 2025

ping

@tstellar
Copy link
Collaborator

@sebpop, you have been granted commit access. Please review the project's code review policy before submitting a patch.

@sebpop
Copy link
Contributor Author

sebpop commented Jan 29, 2025

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants