Skip to content

MCAsmStreamer: Omit initial ".text" causing lot of breakages #121119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavk opened this issue Dec 26, 2024 · 2 comments
Closed

MCAsmStreamer: Omit initial ".text" causing lot of breakages #121119

pranavk opened this issue Dec 26, 2024 · 2 comments
Labels
mc Machine (object) code question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@pranavk
Copy link
Contributor

pranavk commented Dec 26, 2024

@MaskRay

7b23f41#diff-c1cd0d8700618033d5c6439791e7203361e531ee49f9a53865ca158302a79adc is causing us a lot of problems. I know you have changed all the tests that were dependent on it in the LLVM repo but it's a disruptive change in general. I am trying to fix-forward but failing that, could we revert this and reland it later after the holidays?

@EugeneZelenko EugeneZelenko added mc Machine (object) code and removed new issue labels Dec 26, 2024
@MaskRay
Copy link
Member

MaskRay commented Dec 26, 2024

How is this disruptive at all? Do you have a downstream llvm/lib/Target/XXX with many tests expect implicit .text? The fix is mechanical.

You can also hack initSections to use switchSection instead of switchSectionNoPrint for your targets.

@pranavk
Copy link
Contributor Author

pranavk commented Dec 27, 2024

Ok. ended up working around it. Sorry for the noise.

@pranavk pranavk closed this as completed Dec 27, 2024
@EugeneZelenko EugeneZelenko added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc Machine (object) code question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
None yet
Development

No branches or pull requests

3 participants