19.1.2 linux build failure on armv7l from 19.1.0: Building ARMTargetParserDef.inc... (Due to using broken mold 1.34.0)

[satmandu]

This is what we are seeing building 19.1.2 on armv7l. Builds succeed for x86_64 and i686:

-- Performing Test HAVE_UINT8T - Failed
-- Performing Test HAVE_INTTYPES_H
-- Performing Test HAVE_INTTYPES_H - Success
-- Performing Test HAVE_SYS_INTTYPES_H
-- Performing Test HAVE_SYS_INTTYPES_H - Failed
-- Registering Polly as a pass plugin (static build: ON)
-- Registering ExampleIRTransforms as a pass plugin (static build: OFF)
-- Registering Bye as a pass plugin (static build: OFF)                
-- Configuring done (91.0s)                                                                                       
-- Generating done (8.7s)
-- Build files have been written to: /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir                       
ninja: Entering directory `builddir'
[193*4/7501] Building ARMTargetParserDef.inc...
FAILED: include/llvm/TargetParser/ARMTargetParserDef.inc /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/include/llvm/TargetParser/ARMTargetParserDef.inc
cd /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir && /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/bin/llvm-min-tblgen -gen-arm-target-def -I /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/lib/Target/ARM/ -I /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/include/llvm/TargetParser -I/usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/include -I/usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/include /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/lib/Target/ARM/ARM.td --write-if-changed -o include/llvm/TargetParser/ARMTargetParserDef.inc -d include/llvm/TargetParser/ARMTargetParserDef.inc.d
[195*1/7501] Building CXX object lib/Deb...ew.dir/DebugInlineeLinesSubsection.cpp.o
ninja: build stopped: subcommand failed.

clang --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd7cfb1a1421ba92bca9d017b49936c55e4)
Target: armv7l-cros-linux-gnueabihf
Thread model: posix
InstalledDir: /usr/local/bin
clang++ --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd7cfb1a1421ba92bca9d017b49936c55e4)
Target: armv7l-cros-linux-gnueabihf
Thread model: posix
InstalledDir: /usr/local/bin

[satmandu]

The only possible connection I am seeing is to #88378 but we didn't have a problem building 19.1.0.

[llvmbot]

@llvm/issue-subscribers-backend-arm

Author: Satadru Pramanik, DO, MPH, MEng (satmandu)

This is what we are seeing building 19.1.2 on armv7l. Builds succeed for x86_64 and i686:

-- Performing Test HAVE_UINT8T - Failed
-- Performing Test HAVE_INTTYPES_H
-- Performing Test HAVE_INTTYPES_H - Success
-- Performing Test HAVE_SYS_INTTYPES_H
-- Performing Test HAVE_SYS_INTTYPES_H - Failed
-- Registering Polly as a pass plugin (static build: ON)
-- Registering ExampleIRTransforms as a pass plugin (static build: OFF)
-- Registering Bye as a pass plugin (static build: OFF)                
-- Configuring done (91.0s)                                                                                       
-- Generating done (8.7s)
-- Build files have been written to: /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir                       
ninja: Entering directory `builddir'
[193*4/7501] Building ARMTargetParserDef.inc...
FAILED: include/llvm/TargetParser/ARMTargetParserDef.inc /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/include/llvm/TargetParser/ARMTargetParserDef.inc
cd /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir && /usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/bin/llvm-min-tblgen -gen-arm-target-def -I /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/lib/Target/ARM/ -I /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/include/llvm/TargetParser -I/usr/local/tmp/crew/llvm19_build.20241015211726.dir/builddir/include -I/usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/include /usr/local/tmp/crew/llvm19_build.20241015211726.dir/llvm/lib/Target/ARM/ARM.td --write-if-changed -o include/llvm/TargetParser/ARMTargetParserDef.inc -d include/llvm/TargetParser/ARMTargetParserDef.inc.d
[195*1/7501] Building CXX object lib/Deb...ew.dir/DebugInlineeLinesSubsection.cpp.o
ninja: build stopped: subcommand failed.

clang --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd7cfb1a1421ba92bca9d017b49936c55e4)
Target: armv7l-cros-linux-gnueabihf
Thread model: posix
InstalledDir: /usr/local/bin
clang++ --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd7cfb1a1421ba92bca9d017b49936c55e4)
Target: armv7l-cros-linux-gnueabihf
Thread model: posix
InstalledDir: /usr/local/bin

[DavidSpickett]

Please provide:

• cmake configuration command
• full build log

So we can tell if this is a source problem or a compiler crash or something else (could even be a tablegen crash).

[DavidSpickett]

clang --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd)

Ah, this is your host compiler you're using 19.1.0 to build 19.2.0?

If you are, you could try rebuilding 19.1.0 with 19.1.0. If that also fails then it's not a change that came in 19.1.0 causing this.

Edit: 19.1.2 not 19.2.0, you get the idea though :)

[satmandu]

Our build arguments:

cmake -B builddir -G Ninja llvm \
            -DCMAKE_ASM_COMPILER_TARGET=armv7l-cros-linux-gnueabih \
            -DCMAKE_BUILD_TYPE=Release \
            -DCMAKE_C_COMPILER=$(which clang) \
            -DCMAKE_C_COMPILER_LAUNCHER=sccache \
            -DCMAKE_C_COMPILER_TARGET=armv7l-cros-linux-gnueabihf \
            -DCMAKE_C_FLAGS='-fPIC -mfloat-abi=hard -mthumb -mfpu=vfpv3-d16 -march=armv7-a+fp -ccc-gcc-name armv7l-cros-linux-gnueabihf' \
            -DCMAKE_CXX_COMPILER=$(which clang++) \
            -DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
            -DCMAKE_CXX_FLAGS='-fPIC -mfloat-abi=hard -mthumb -mfpu=vfpv3-d16 -march=armv7-a+fp -ccc-gcc-name armv7l-cros-linux-gnueabihf' \
            -DCMAKE_EXE_LINKER_FLAGS='-flto=thin' \
            -DCMAKE_INSTALL_LIBDIR=lib \
            -DCMAKE_INSTALL_PREFIX=/usr/local \
            -DCMAKE_LINKER=$(which ld.lld) \
            -D_CMAKE_TOOLCHAIN_PREFIX=llvm- \
            -DCOMPILER_RT_BUILD_BUILTINS=ON \
            -DCOMPILER_RT_BUILD_LIBFUZZER=OFF \
            -DCOMPILER_RT_BUILD_SANITIZERS=OFF \
            -DCOMPILER_RT_DEFAULT_TARGET_ONLY=ON \
            -DLLDB_INCLUDE_TESTS=OFF \
            -DLLVM_BINUTILS_INCDIR='/usr/local/include' \
            -DLLVM_BUILD_LLVM_DYLIB=ON \
            -DLLVM_DEFAULT_TARGET_TRIPLE=armv7l-cros-linux-gnueabihf \
            -DLLVM_ENABLE_FFI=ON \
            -DLLVM_ENABLE_LTO=Thin \
            -DLLVM_ENABLE_PROJECTS=''clang;clang-tools-extra;compiler-rt;lld;lldb;polly;pstl' \
            -DLLVM_ENABLE_RTTI=ON \
            -DLLVM_INCLUDE_BENCHMARKS=OFF \
            -DLLVM_INSTALL_UTILS=ON \
            -DLLVM_LINK_LLVM_DYLIB=ON \
            -DLLVM_OPTIMIZED_TABLEGEN=ON \
            -DLLVM_TARGETS_TO_BUILD=all' \
            -Wno-dev"

[satmandu]

clang --version
clang version 19.1.0 (https://github.com/llvm/llvm-project.git a4bf6cd)

Ah, this is your host compiler you're using 19.1.0 to build 19.2.0?

If you are, you could try rebuilding 19.1.0 with 19.1.0. If that also fails then it's not a change that came in 19.1.0 causing this.

llvm 19.1.0 was built with llvm 18.1.8. I can try rebuilding llvm 19.1.0 with llvm 19.1.0...

[satmandu]

Currently trying to build 19.1.0 with llvm 18.1.8...

[DavidSpickett]

The full ninja logs should tell you exactly, but just from the snippet I think it's building the .inc file:

llvm-project/llvm/include/llvm/TargetParser/CMakeLists.txt

Line 2 in d9c95ef

tablegen(LLVM ARMTargetParserDef.inc -gen-arm-target-def -I ${PROJECT_SOURCE_DIR}/lib/Target/ARM/)

This doesn't actually use clang but the tablegen compiler (./bin/llvm-tblgen) which is built in the early stages of the build. So it may be that the change you highlighted is ok in itself but has managed to make the tablegen compiler hit incorrect code generation which was done by clang.

(this .inc file is later included in C++ files that do go to the C++ compiler)

[satmandu]

Building with 18.1.8 I'm getting the same error:

ninja: Entering directory `builddir'
[193*4/7500] Building ARMTargetParserDef.inc...
FAILED: include/llvm/TargetParser/ARMTargetParserDef.inc /usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir/include/llvm/TargetParser/ARMTargetParserDef.inc                                        cd /usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir && /usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir/bin/llvm-min-tblgen -gen-arm-target-def -I /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/lib/Target/ARM/ -I /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/include/llvm/TargetParser -I/usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir/include -I/usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/include /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/lib/Target/ARM/ARM.td --write-if-changed -o include/llvm/TargetParser/ARMTargetParserDef.inc -d include/llvm/TargetParser/ARMTargetParserDef.inc.d
[195*1/7500] Building CXX object lib/DebugInfo/CodeView/CM...LVMDebugInfoCodeView.dir/DebugInlineeLinesSubsection.cpp.o
ninja: build stopped: subcommand failed.

As you point out @DavidSpickett it is using an in-build generated llvm-min-tblgen, so I'm not sure why it is breaking now and not a month ago when we did the initial builds of 19.1.0.

Let me try build this again and get the logs... Which ninja files do you need from the builddir?

[DavidSpickett]

.ninja_log but now I look at it, it's not the full output I thought it would be.

You may have better luck manually executing the command that it says failed. As in:

cd /usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir && /usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir/bin/llvm-min-tblgen -gen-arm-target-def -I /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/lib/Target/ARM/ -I /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/include/llvm/TargetParser -I/usr/local/tmp/crew/llvm19_build.20241016150512.dir/builddir/include -I/usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/include /usr/local/tmp/crew/llvm19_build.20241016150512.dir/llvm/lib/Target/ARM/ARM.td --write-if-changed -o include/llvm/TargetParser/ARMTargetParserDef.inc -d include/llvm/TargetParser/ARMTargetParserDef.inc.d

And seeing if you get any more output from it.

[satmandu]

cd /usr/local/tmp/crew/llvm19_build.20241016152025.dir/builddir \
&& /usr/local/tmp/crew/llvm19_build.20241016152025.dir/builddir/bin/llvm-min-tblgen -gen-arm-target-def \
-I /usr/local/tmp/crew/llvm19_build.20241016152025.dir/llvm/lib/Target/ARM/ \
-I /usr/local/tmp/crew/llvm19_build.20241016152025.dir/llvm/include/llvm/TargetParser \
-I/usr/local/tmp/crew/llvm19_build.20241016152025.dir/builddir/include \
-I/usr/local/tmp/crew/llvm19_build.20241016152025.dir/llvm/include /usr/local/tmp/crew/llvm19_build.20241016152025.dir/llvm/lib/Target/ARM/ARM.td \
--write-if-changed -o include/llvm/TargetParser/ARMTargetParserDef.inc \
-d include/llvm/TargetParser/ARMTargetParserDef.inc.d
Segmentation fault