[llvm-objdump][AArch32] Print target address in hexadecimal form

[hstk30-hw]

As testcase llvm/test/MC/ARM/arm-macho-calls.s show

@ CHECK: _func:
@ CHECK:    bl #0 <_func+0x8>
@ CHECK:  ARM_RELOC_BR24 __text
@ CHECK:    bl #-12 <_func>
@ CHECK:  ARM_RELOC_BR24 _elsewhere
    .global _func
_func:
    bl Llocal_symbol
    bl _elsewhere
Llocal_symbol:
    bx lr

    .global _elsewhere
_elsewhere:
    bx lr

Not present the symbol name in assembly.

I hope it present like below:

@ CHECK: <_func>:
@ CHECK:    bl 0x8 <__text> @ imm = #0
@ CHECK:  ARM_RELOC_BR24 __text
@ CHECK:    bl 0x0 <_elsewhere> @ imm = #-12
@ CHECK:  ARM_RELOC_BR24 _elsewhere
    .global _func
_func:
    bl Llocal_symbol
    bl _elsewhere
Llocal_symbol:
    bx lr

    .global _elsewhere
_elsewhere:
    bx lr

That's what GNU objdump work. No symbol name make me confused sometimes.

[hstk30-hw]

CC @igorkudrin @TNorthover @MaskRay

[llvmbot]

@llvm/issue-subscribers-tools-llvm-objdump

Author: None (hstk30-hw)

As testcase llvm/test/MC/ARM/arm-macho-calls.s show

@ CHECK: _func:
@ CHECK:    bl #<!-- -->0 &lt;_func+0x8&gt;
@ CHECK:  ARM_RELOC_BR24 __text
@ CHECK:    bl #-12 &lt;_func&gt;
@ CHECK:  ARM_RELOC_BR24 _elsewhere
    .global _func
_func:
    bl Llocal_symbol
    bl _elsewhere
Llocal_symbol:
    bx lr

    .global _elsewhere
_elsewhere:
    bx lr

Not present the symbol name in assembly.

I hope it present like below:

@ CHECK: <_func>:
@ CHECK:    bl 0x8 &lt;__text&gt; @ imm = #<!-- -->0
@ CHECK:  ARM_RELOC_BR24 __text
@ CHECK:    bl 0x0 &lt;_elsewhere&gt; @ imm = #-12
@ CHECK:  ARM_RELOC_BR24 _elsewhere
    .global _func
_func:
    bl Llocal_symbol
    bl _elsewhere
Llocal_symbol:
    bx lr

    .global _elsewhere
_elsewhere:
    bx lr

That's what GNU objdump work. No symbol name make me confused sometimes.

[MaskRay]

The feature request is: display target addresses instead of relative #imm. I've made patches like
https://reviews.llvm.org/D93241 to change a few architectures, but I don't have interest in changing AArch32.

[hstk30-hw]

The more explicit example like below. I have the code

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int foo(int *A, int n) {
  unsigned sum = 0;
  for (int i = 0; i < n; ++i)
    sum += A[i] + 5;
  return sum;
}

int main() {
    char array[2] = {0};
    strcpy(array, "aaaaaaaaaa");
    printf("%s\n",array);

    return 0;
}

compiler and link it like clang -fstack-protector-strong test.c -o test
then llvm-objdump -d test

It not present the

bl      0 <__stack_chk_fail>

It print like

   10758: e1500001      cmp     r0, r1
   1075c: 1a000002      bne     0x1076c <main+0x94>     @ imm = #8
   10760: e3000000      movw    r0, #0
   10764: e1a0d00b      mov     sp, r11
   10768: e8bd8800      pop     {r11, pc}
   1076c: eb000037      bl      0x10850 <strcpy+0x10850> @ imm = #220

I have seen those patch, do you think it's the matter of InstPrinter?