[CIR][Dialect] Emit OpenCL kernel argument metadata #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bcardosolopes merged 3 commits into llvm:main from seven-mile:kernel-arg-metadata

Aug 2, 2024

Collaborator

seven-mile commented Aug 2, 2024

Similar to #705, this PR implements the remaining genKernelArgMetadata() logic.

The attribute cir.cl.kernel_arg_metadata is also intentionally placed in the cir.func's extra_attrs rather than cir.func's standard arg_attrs list. Also, the metadata is stored by Array with proper verification on it. See the tablegen doc string for details.

This is in order to

keep it side-by-side with cl.kernel_metadata.
still emit metadata when kernel has an empty arg list (see the test kernel-arg-meatadata.cl).
avoid horrors of repeating the long name cir.cl.kernel_arg_metadata for numArgs times.

Because clangir doesn't support OpenCL built-in types and the half floating point type yet, their changes and test cases are not included. Corresponding missing feature flag is added.

seven-mile added 3 commits

August 2, 2024 09:56


          [CIR][Dialect] OpenCL kernel argument metadata

72d3a5e


          better llvm file check in test

255b915


          add verification

5bb7603

seven-mile requested review from bcardosolopes and lanza as code owners

August 2, 2024 04:06

bcardosolopes approved these changes

View reviewed changes

Member

bcardosolopes left a comment

LGTM. I added some refactoring requirements but feel free to do them in a follow up PR. Thanks!

clang/lib/CIR/CodeGen/CIRGenModule.cpp

    
              // for example in clGetKernelArgInfo() implementation between the address

              // spaces with targets without unique mapping to the OpenCL address spaces

              // (basically all single AS CPUs).

              static unsigned ArgInfoAddressSpace(LangAS AS) {

Member

bcardosolopes Aug 2, 2024

Please add a CIRGenOpenCL.cpp and lets starting put all this specific info over there for implementations. Both of the new functions/methods here qualify.

clang/lib/CIR/Dialect/IR/CIRAttrs.cpp

    
              // OpenCLKernelArgMetadataAttr definitions

              //===----------------------------------------------------------------------===//

              LogicalResult OpenCLKernelArgMetadataAttr::verify(

Member

bcardosolopes Aug 2, 2024

Same for these bits, please add a CIROpenCLAttrs.cpp.

bcardosolopes merged commit f9f0970 into llvm:main

seven-mile mentioned this pull request

[CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V target #773

Merged

bcardosolopes pushed a commit that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

ccac403

…arget (#773)

Similar to #767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

seven-mile mentioned this pull request

[GSoC] Add OpenCL support to compile GPU kernels #689

Closed

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (llvm#767)

790d303

Similar to llvm#705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

417b460

…arget (llvm#773)

Similar to llvm#767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (llvm#767)

e700fed

Similar to llvm#705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

1a65766

…arget (llvm#773)

Similar to llvm#767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (llvm#767)

675c546

Similar to llvm#705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

smeenai pushed a commit to smeenai/clangir that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

32dc02e

…arget (llvm#773)

Similar to llvm#767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (llvm#767)

aa85d46

Similar to llvm#705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

keryell pushed a commit to keryell/clangir that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

fc230fb

…arget (llvm#773)

Similar to llvm#767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

lanza pushed a commit that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (#767)

c99ff03

Similar to #705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

fd779b8

…arget (#773)

Similar to #767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

lanza pushed a commit that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (#767)

0d73e57

Similar to #705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

lanza pushed a commit that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

e7698a1

…arget (#773)

Similar to #767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request


          [CIR][Dialect] Emit OpenCL kernel argument metadata (llvm#767)

239026c

Similar to llvm#705, this PR implements the remaining
`genKernelArgMetadata()` logic.

The attribute `cir.cl.kernel_arg_metadata` is also intentionally placed
in the `cir.func`'s `extra_attrs` rather than `cir.func`'s standard
`arg_attrs` list. Also, the metadata is stored by `Array` with proper
verification on it. See the tablegen doc string for details.

This is in order to
* keep it side-by-side with `cl.kernel_metadata`.
* still emit metadata when kernel has an *empty* arg list (see the test
`kernel-arg-meatadata.cl`).
* avoid horrors of repeating the long name `cir.cl.kernel_arg_metadata`
for `numArgs` times.

Because clangir doesn't support OpenCL built-in types and the `half`
floating point type yet, their changes and test cases are not included.
Corresponding missing feature flag is added.

terapines-osc-cir pushed a commit to Terapines/clangir that referenced this pull request


          [CIR][CodeGen][LowerToLLVM] Emit OpenCL version metadata for SPIR-V t…

3eeed4d

…arget (llvm#773)

Similar to llvm#767, this PR emit the module level OpenCL version metadata
following the OG CodeGen skeleton.

We use a full qualified `cir.cl.version` attribute on the module op to
store the info in CIR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet