[CIR] Implement __builtin_ia32_cmpnltps/cmpnltpd #1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badumbatish
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Member
|
Thanks for working on this. If you need to stack PRs you gotta use something like https://llvm.org/docs/GitHub.html#stacked-pull-requests, otherwise it's double the work for reviewers. Alternatively you can let me know once the dependency land and then I'll take a look into this one. |
Contributor
Author
|
yep, ty, will ping you once the other PR merges |
Contributor
Author
|
@bcardosolopes hi Bruno, this one should be good for review |
bcardosolopes
approved these changes
Sep 23, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM after addressing existing comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports for __builtin_ia32_cmpnltps/cmpnltpd.
Depends on #1893.