[CIR][CIRGen][Builtin][X86] Lower palignr intrinsics
#1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiverDave
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
tommymcm
reviewed
Sep 8, 2025
Collaborator
tommymcm
left a comment
tommymcm
left a comment
There was a problem hiding this comment.
Needs a couple of tests for coverage
RiverDave
force-pushed
the
dave/lower-palingr
branch
from
9c31755 to
6b70ee1
Compare
Collaborator
Author
Thanks, OG had some tests related to those branches you mention [here].(https://github.com/llvm/clangir/blob/main/clang/test/CodeGen/palignr.c) I couldn't replicate the test suite exactly with the CIR pipeline given that the test wouldn't compile when adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.