[CIR] Add support for delegating ctor with VTT #1890
Merged
+280
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the code for emitting delegating constructors with VTT arguments.
andykaylor
requested review from
bcardosolopes,
lanza and
xlauko
as code owners
Collaborator
Author
|
FYI, I am making the same change upstream here: llvm/llvm-project#156970 |
bcardosolopes
approved these changes
Sep 5, 2025
tommymcm
pushed a commit
to tommymcm/clangir
that referenced
this pull request
Sep 5, 2025
This implements getting the VTT argument for a delegating constructor and enables the corresponding test in delegating-ctor.cpp.
bcardosolopes
added a commit
that referenced
this pull request
Sep 5, 2025
This reverts commit a896c41. Test is failing on Linux (reproduced locally)
Member
|
Had to revert because it broke test on Linux: |
Member
|
@andykaylor ^ (just in case closed PRs get filtered by your email / conf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements getting the VTT argument for a delegating constructor and enables the corresponding test in delegating-ctor.cpp.