[CIR] Fix element type for lowering vtt.address_point #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While upstreaming vtt.address_point lowering, I noticed an important difference in the LLVM IR generated between the CIR path and the OGCG path. We were incorrectly using i8 as the element type for the GEP generated when vtt.address_point is lowered with a value argument. This patch fixes that.
andykaylor
requested review from
bcardosolopes,
lanza and
xlauko
as code owners
erichkeane
approved these changes
Aug 29, 2025
bcardosolopes
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upstreaming vtt.address_point lowering, I noticed an important difference in the LLVM IR generated between the CIR path and the OGCG path. We were incorrectly using i8 as the element type for the GEP generated when vtt.address_point is lowered with a value argument. This patch fixes that.