[CIR] Add BlockAddressOp #1875
Merged
[CIR] Add BlockAddressOp #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Andres-Salamanca
left a comment
Andres-Salamanca
left a comment
There was a problem hiding this comment.
@andykaylor @bcardosolopes @xlauko I’m unsure about the right way to approach these cases. Do you have any suggestions?
Andres-Salamanca
commented
Sep 2, 2025
Andres-Salamanca
requested review from
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
requested changes
Sep 3, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for working on this, pretty cool, added first round of review!
Contributor
Author
Andres-Salamanca
left a comment
Andres-Salamanca
left a comment
There was a problem hiding this comment.
Sorry for the late reply, @andykaylor , @bcardosolopes . I haven’t had much time lately, so this can still be improved, but I’d like to know how I’m doing so far.
bcardosolopes
requested changes
Sep 12, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Let's break this PR into two for making the review easier. For this one:
- Add CIR + tests for CIR to CIR parsing/printing.
- CIRGen support. Tests will only contain the
CIRpart. - GotoSolver support, add test that verify only unused labels are removed.
- Add the verifier mentioned in the comments for
verifyBlockTagsand add a CIR test for it.
All LLVM lowering should be deferred to a next PR. Inline comments also added
bcardosolopes
approved these changes
Sep 18, 2025
Member
|
Needs some conflict fixes but ready to go |
Andres-Salamanca
force-pushed
the
block-addr
branch
from
cc869e1 to
8c51d1e
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
BlockAddressOp, used for GCC labels as values.Support for indirect
gotoandConstantLValueEmitter::VisitAddrLabelExprwill be added in a future PR.